From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: RFA: probable rs6000-aix-tdep.c bug found by clang
Date: Wed, 17 Oct 2012 20:06:00 -0000 [thread overview]
Message-ID: <87mwzk279g.fsf@fleche.redhat.com> (raw)
Here is another patch for a bug found by clang.
rs6000-aix-tdep.c:rs6000_aix_osabi_sniffer has an extraneous ";" that
makes the initial "if" irrelevant.
Based on indentation and logic I think that the fix is to remove the ";".
However, I have no decent way to test this and would appreciate someone
else looking at it.
Tom
2012-10-17 Tom Tromey <tromey@redhat.com>
* rs6000-aix-tdep.c (rs6000_aix_osabi_sniffer): Remove extraneous
semicolon.
diff --git a/gdb/rs6000-aix-tdep.c b/gdb/rs6000-aix-tdep.c
index 59cfa73..749c109 100644
--- a/gdb/rs6000-aix-tdep.c
+++ b/gdb/rs6000-aix-tdep.c
@@ -723,7 +723,7 @@ static enum gdb_osabi
rs6000_aix_osabi_sniffer (bfd *abfd)
{
- if (bfd_get_flavour (abfd) == bfd_target_xcoff_flavour);
+ if (bfd_get_flavour (abfd) == bfd_target_xcoff_flavour)
return GDB_OSABI_AIX;
return GDB_OSABI_UNKNOWN;
next reply other threads:[~2012-10-17 20:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 20:06 Tom Tromey [this message]
2012-10-17 21:24 ` Joel Brobecker
2012-10-18 9:10 ` Pedro Alves
2012-10-18 15:33 ` Joel Brobecker
2012-10-18 15:46 ` Pedro Alves
2012-10-18 15:58 ` Joel Brobecker
2012-10-18 16:06 ` Pedro Alves
2012-10-18 18:49 ` Joel Brobecker
2012-10-18 19:43 ` Tom Tromey
2012-10-19 20:00 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwzk279g.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox