From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: RFA: probable rs6000-aix-tdep.c bug found by clang
Date: Thu, 18 Oct 2012 15:46:00 -0000 [thread overview]
Message-ID: <5080244B.30601@redhat.com> (raw)
In-Reply-To: <20121018153304.GS3050@adacore.com>
On 10/18/2012 04:33 PM, Joel Brobecker wrote:
>>>> * rs6000-aix-tdep.c (rs6000_aix_osabi_sniffer): Remove extraneous
>>>> semicolon.
>>
>> I suspect this is the root cause of PR8966 (AIX 5.1 single_step configuration
>> is broken). http://sourceware.org/bugzilla/show_bug.cgi?id=8966
>>
>> We're always returning the _UNKNOWN osabi, so this is unreachable:
>
> On the contrary, I think we always returned the AIX osabi.
Duh. You're right.
I now notice the PR predates the patch that added this (a8cfed2a), and it seems the
patch was meant to fix exactly that single-step issue in the PR. So I guess we
could close it.
Searching bugzilla for aix finds a handful of PRs, and most looks quite old. I'd be
nice to give them a little triage love. :-)
>>> So, isn't rs6000_aix_osabi_sniffer going to be called if, and only
>>> if, the bfd has a bfd_target_xcoff_flavour, thus making the check
>>> superfluous?
>>
>> Sure looks like it.
>
> OK - I will take care of removing the condition and simplifying
> the function.
--
Pedro Alves
next prev parent reply other threads:[~2012-10-18 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 20:06 Tom Tromey
2012-10-17 21:24 ` Joel Brobecker
2012-10-18 9:10 ` Pedro Alves
2012-10-18 15:33 ` Joel Brobecker
2012-10-18 15:46 ` Pedro Alves [this message]
2012-10-18 15:58 ` Joel Brobecker
2012-10-18 16:06 ` Pedro Alves
2012-10-18 18:49 ` Joel Brobecker
2012-10-18 19:43 ` Tom Tromey
2012-10-19 20:00 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5080244B.30601@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox