From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9867 invoked by alias); 18 Oct 2012 15:46:30 -0000 Received: (qmail 9805 invoked by uid 22791); 18 Oct 2012 15:46:28 -0000 X-SWARE-Spam-Status: No, hits=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Oct 2012 15:46:23 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9IFkLcq001772 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 18 Oct 2012 11:46:21 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9IFkJYI016198; Thu, 18 Oct 2012 11:46:20 -0400 Message-ID: <5080244B.30601@redhat.com> Date: Thu, 18 Oct 2012 15:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 MIME-Version: 1.0 To: Joel Brobecker CC: Tom Tromey , gdb-patches@sourceware.org Subject: Re: RFA: probable rs6000-aix-tdep.c bug found by clang References: <87mwzk279g.fsf@fleche.redhat.com> <20121017212417.GP3050@adacore.com> <507FC786.50400@redhat.com> <20121018153304.GS3050@adacore.com> In-Reply-To: <20121018153304.GS3050@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00328.txt.bz2 On 10/18/2012 04:33 PM, Joel Brobecker wrote: >>>> * rs6000-aix-tdep.c (rs6000_aix_osabi_sniffer): Remove extraneous >>>> semicolon. >> >> I suspect this is the root cause of PR8966 (AIX 5.1 single_step configuration >> is broken). http://sourceware.org/bugzilla/show_bug.cgi?id=8966 >> >> We're always returning the _UNKNOWN osabi, so this is unreachable: > > On the contrary, I think we always returned the AIX osabi. Duh. You're right. I now notice the PR predates the patch that added this (a8cfed2a), and it seems the patch was meant to fix exactly that single-step issue in the PR. So I guess we could close it. Searching bugzilla for aix finds a handful of PRs, and most looks quite old. I'd be nice to give them a little triage love. :-) >>> So, isn't rs6000_aix_osabi_sniffer going to be called if, and only >>> if, the bfd has a bfd_target_xcoff_flavour, thus making the check >>> superfluous? >> >> Sure looks like it. > > OK - I will take care of removing the condition and simplifying > the function. -- Pedro Alves