From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3223 invoked by alias); 17 Oct 2012 20:06:30 -0000 Received: (qmail 3215 invoked by uid 22791); 17 Oct 2012 20:06:29 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Oct 2012 20:06:20 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9HK6Kps001319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Oct 2012 16:06:20 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q9HK6JlR009441 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 17 Oct 2012 16:06:19 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Subject: RFA: probable rs6000-aix-tdep.c bug found by clang Date: Wed, 17 Oct 2012 20:06:00 -0000 Message-ID: <87mwzk279g.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00303.txt.bz2 Here is another patch for a bug found by clang. rs6000-aix-tdep.c:rs6000_aix_osabi_sniffer has an extraneous ";" that makes the initial "if" irrelevant. Based on indentation and logic I think that the fix is to remove the ";". However, I have no decent way to test this and would appreciate someone else looking at it. Tom 2012-10-17 Tom Tromey * rs6000-aix-tdep.c (rs6000_aix_osabi_sniffer): Remove extraneous semicolon. diff --git a/gdb/rs6000-aix-tdep.c b/gdb/rs6000-aix-tdep.c index 59cfa73..749c109 100644 --- a/gdb/rs6000-aix-tdep.c +++ b/gdb/rs6000-aix-tdep.c @@ -723,7 +723,7 @@ static enum gdb_osabi rs6000_aix_osabi_sniffer (bfd *abfd) { - if (bfd_get_flavour (abfd) == bfd_target_xcoff_flavour); + if (bfd_get_flavour (abfd) == bfd_target_xcoff_flavour) return GDB_OSABI_AIX; return GDB_OSABI_UNKNOWN;