From: Tom Tromey <tromey@redhat.com>
To: kv.bhat@samsung.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary
Date: Mon, 19 Nov 2012 15:50:00 -0000 [thread overview]
Message-ID: <87mwydr3so.fsf@fleche.redhat.com> (raw)
In-Reply-To: <10412685.433941353312405484.JavaMail.weblogic@epml02> (KARTHIKVENKATESH BHAT's message of "Mon, 19 Nov 2012 08:06:45 +0000 (GMT)")
>>>>> "Karthik" == KARTHIKVENKATESH BHAT <kv.bhat@samsung.com> writes:
Karthik> I wanted to add a patch in i386-tdep.c . Similar to what is done in
Karthik> other architectures such as ARM,
Karthik> instead of actually going through the complete prologue if we can use
Karthik> the symbol table information to resolve prologue end.
I'm not the person to review this patch, but I did notice that it is
missing a ChangeLog entry and also a test case.
Karthik> + || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0
Karthik> + || strncmp (s->producer, "clang ", sizeof ("clang ") - 1) == 0))
Is there any other way?
Tom
next prev parent reply other threads:[~2012-11-19 15:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 8:07 KARTHIKVENKATESH BHAT
2012-11-19 14:43 ` H.J. Lu
2012-11-19 15:50 ` Tom Tromey [this message]
2012-11-20 4:58 KARTHIKVENKATESH BHAT
2012-11-21 13:11 ` Pedro Alves
2012-11-21 13:20 ` Mark Kettenis
2012-11-21 14:11 ` Pedro Alves
2012-11-21 15:39 KARTHIKVENKATESH BHAT
2012-11-21 15:53 ` Pedro Alves
2012-11-27 11:14 ` Mark Kettenis
2012-11-27 13:47 KARTHIKVENKATESH BHAT
2012-11-27 15:59 ` Tom Tromey
2012-12-04 6:09 KARTHIKVENKATESH BHAT
[not found] ` <201212040709.qB479ppK023958@glazunov.sibelius.xs4all.nl>
2012-12-04 23:29 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwydr3so.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kv.bhat@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox