From: Tom Tromey <tromey@redhat.com>
To: kv.bhat@samsung.com
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
"palves\@redhat.com" <palves@redhat.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary
Date: Tue, 27 Nov 2012 15:59:00 -0000 [thread overview]
Message-ID: <87ip8rdolf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <14518405.70871354024013896.JavaMail.weblogic@epml11> (KARTHIKVENKATESH BHAT's message of "Tue, 27 Nov 2012 13:46:55 +0000 (GMT)")
>>>>> "Karthik" == KARTHIKVENKATESH BHAT <kv.bhat@samsung.com> writes:
Karthik> Please find the Changes after comments -
There are some formatting issues in the patch.
Karthik> + /* Clang always emits a line note before the prologue and another
Karthik> + one after.We trust clang to emit usable line notes */
Two spaces after the ".".
A "." followed by 2 spaces at the end of the second sentence.
Karthik> + return max(start_pc,post_prologue_pc);
Space before open paren and after the comma.
Tom
next prev parent reply other threads:[~2012-11-27 15:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 13:47 KARTHIKVENKATESH BHAT
2012-11-27 15:59 ` Tom Tromey [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-04 6:09 KARTHIKVENKATESH BHAT
[not found] ` <201212040709.qB479ppK023958@glazunov.sibelius.xs4all.nl>
2012-12-04 23:29 ` Doug Evans
2012-11-21 15:39 KARTHIKVENKATESH BHAT
2012-11-21 15:53 ` Pedro Alves
2012-11-27 11:14 ` Mark Kettenis
2012-11-20 4:58 KARTHIKVENKATESH BHAT
2012-11-21 13:11 ` Pedro Alves
2012-11-21 13:20 ` Mark Kettenis
2012-11-21 14:11 ` Pedro Alves
2012-11-19 8:07 KARTHIKVENKATESH BHAT
2012-11-19 14:43 ` H.J. Lu
2012-11-19 15:50 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ip8rdolf.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kv.bhat@samsung.com \
--cc=mark.kettenis@xs4all.nl \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox