From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29695 invoked by alias); 27 Nov 2012 15:59:05 -0000 Received: (qmail 29675 invoked by uid 22791); 27 Nov 2012 15:59:03 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Nov 2012 15:58:58 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qARFwt6b011237 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Nov 2012 10:58:55 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qARFwr7E024603 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 27 Nov 2012 10:58:53 -0500 From: Tom Tromey To: kv.bhat@samsung.com Cc: Mark Kettenis , "palves\@redhat.com" , "gdb-patches\@sourceware.org" Subject: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary References: <14518405.70871354024013896.JavaMail.weblogic@epml11> Date: Tue, 27 Nov 2012 15:59:00 -0000 In-Reply-To: <14518405.70871354024013896.JavaMail.weblogic@epml11> (KARTHIKVENKATESH BHAT's message of "Tue, 27 Nov 2012 13:46:55 +0000 (GMT)") Message-ID: <87ip8rdolf.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00751.txt.bz2 >>>>> "Karthik" == KARTHIKVENKATESH BHAT writes: Karthik> Please find the Changes after comments - There are some formatting issues in the patch. Karthik> + /* Clang always emits a line note before the prologue and another Karthik> + one after.We trust clang to emit usable line notes */ Two spaces after the ".". A "." followed by 2 spaces at the end of the second sentence. Karthik> + return max(start_pc,post_prologue_pc); Space before open paren and after the comma. Tom