From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: palves@redhat.com
Cc: kv.bhat@samsung.com, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary
Date: Wed, 21 Nov 2012 13:20:00 -0000 [thread overview]
Message-ID: <201211211320.qALDKJth029821@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <50ACD2DF.6000503@redhat.com> (message from Pedro Alves on Wed, 21 Nov 2012 13:10:55 +0000)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
> Date: Wed, 21 Nov 2012 13:10:55 +0000
> From: Pedro Alves <palves@redhat.com>
>
> I updated my checkout this morning and stumbled on:
>
> ../../src/gdb/i386-tdep.c: In function ‘i386_skip_prologue’:
> ../../src/gdb/i386-tdep.c:1586:3: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
> cc1: all warnings being treated as errors
>
> I also noticed the indentation of the if block is not according to
> the convention.
>
> I can't find an email approving the change. Was there some private
> discussion perhaps?
I did not approve that change. I haven't had the time to properly
review the change yet, but it is almost certainly wrong. Please back
it out.
next prev parent reply other threads:[~2012-11-21 13:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 4:58 KARTHIKVENKATESH BHAT
2012-11-21 13:11 ` Pedro Alves
2012-11-21 13:20 ` Mark Kettenis [this message]
2012-11-21 14:11 ` Pedro Alves
-- strict thread matches above, loose matches on Subject: below --
2012-12-04 6:09 KARTHIKVENKATESH BHAT
[not found] ` <201212040709.qB479ppK023958@glazunov.sibelius.xs4all.nl>
2012-12-04 23:29 ` Doug Evans
2012-11-27 13:47 KARTHIKVENKATESH BHAT
2012-11-27 15:59 ` Tom Tromey
2012-11-21 15:39 KARTHIKVENKATESH BHAT
2012-11-21 15:53 ` Pedro Alves
2012-11-27 11:14 ` Mark Kettenis
2012-11-19 8:07 KARTHIKVENKATESH BHAT
2012-11-19 14:43 ` H.J. Lu
2012-11-19 15:50 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211211320.qALDKJth029821@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=kv.bhat@samsung.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox