From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-96128-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32371 invoked by alias); 21 Nov 2012 13:20:52 -0000
Received: (qmail 32320 invoked by uid 22791); 21 Nov 2012 13:20:49 -0000
X-SWARE-Spam-Status: No, hits=-3.2 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 21 Nov 2012 13:20:40 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id qALDKLLx008477;	Wed, 21 Nov 2012 14:20:21 +0100 (CET)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id qALDKJth029821;	Wed, 21 Nov 2012 14:20:19 +0100 (CET)
Date: Wed, 21 Nov 2012 13:20:00 -0000
Message-Id: <201211211320.qALDKJth029821@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: palves@redhat.com
CC: kv.bhat@samsung.com, gdb-patches@sourceware.org
In-reply-to: <50ACD2DF.6000503@redhat.com> (message from Pedro Alves on Wed,	21 Nov 2012 13:10:55 +0000)
Subject: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary
References: <12011231.483671353387478250.JavaMail.weblogic@epml02> <50ACD2DF.6000503@redhat.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-11/txt/msg00566.txt.bz2

> Date: Wed, 21 Nov 2012 13:10:55 +0000
> From: Pedro Alves <palves@redhat.com>
> 
> I updated my checkout this morning and stumbled on:
> 
> ../../src/gdb/i386-tdep.c: In function ‘i386_skip_prologue’:
> ../../src/gdb/i386-tdep.c:1586:3: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
> cc1: all warnings being treated as errors
> 
> I also noticed the indentation of the if block is not according to
> the convention.
> 
> I can't find an email approving the change.  Was there some private
> discussion perhaps?

I did not approve that change.  I haven't had the time to properly
review the change yet, but it is almost certainly wrong.  Please back
it out.