From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12133 invoked by alias); 19 Nov 2012 15:50:08 -0000 Received: (qmail 12039 invoked by uid 22791); 19 Nov 2012 15:50:06 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Nov 2012 15:49:32 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAJFnT7B023832 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Nov 2012 10:49:30 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qAJFnRZl014305 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 19 Nov 2012 10:49:28 -0500 From: Tom Tromey To: kv.bhat@samsung.com Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix for incorect breakpoint set in case of clang compiled binary References: <10412685.433941353312405484.JavaMail.weblogic@epml02> Date: Mon, 19 Nov 2012 15:50:00 -0000 In-Reply-To: <10412685.433941353312405484.JavaMail.weblogic@epml02> (KARTHIKVENKATESH BHAT's message of "Mon, 19 Nov 2012 08:06:45 +0000 (GMT)") Message-ID: <87mwydr3so.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00508.txt.bz2 >>>>> "Karthik" == KARTHIKVENKATESH BHAT writes: Karthik> I wanted to add a patch in i386-tdep.c . Similar to what is done in Karthik> other architectures such as ARM, Karthik> instead of actually going through the complete prologue if we can use Karthik> the symbol table information to resolve prologue end. I'm not the person to review this patch, but I did notice that it is missing a ChangeLog entry and also a test case. Karthik> + || strncmp (s->producer, "GNU ", sizeof ("GNU ") - 1) == 0 Karthik> + || strncmp (s->producer, "clang ", sizeof ("clang ") - 1) == 0)) Is there any other way? Tom