* [commit/obvious] Fix PR sim/16018
@ 2013-10-09 21:48 Sergio Durigan Junior
2013-10-10 2:23 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Sergio Durigan Junior @ 2013-10-09 21:48 UTC (permalink / raw)
To: GDB Patches
Hi,
I have committed the following patch as an obvious fix for PR
sim/16018. It just adds missing "break" statements in a switch.
I must confess that I did not manage to build ERC32 sim. What I did
was:
../gdb-src/configure --target=sparc-rtems4.11 --enable-sim --enable-sim-hardware
And I received the following error:
In file included from ../../../../../gdb-src/sim/erc32/../../include/gdb/callback.h:55:0,
from ../../../../../gdb-src/sim/erc32/sis.h:24,
from ../../../../../gdb-src/sim/erc32/exec.c:23:
../../bfd/bfd.h:1070:48: error: unknown type name ‘size_t’
Strange... I did not investigate too much, but maybe I'm doing
something wrong.
Anyway, patch applied.
https://sourceware.org/ml/gdb-cvs/2013-10/msg00064.html
--
Sergio
2013-10-09 Sergio Durigan Junior <sergiodj@redhat.com>
PR sim/16018:
* float.c (set_fsr): Add missing "break" statements. Reindent
code.
diff --git a/sim/erc32/float.c b/sim/erc32/float.c
index c1a46f8..1b8f0fc 100644
--- a/sim/erc32/float.c
+++ b/sim/erc32/float.c
@@ -91,9 +91,16 @@ uint32 fsr;
fsr >>= 30;
switch (fsr) {
case 0:
- case 2: break;
- case 1: fsr = 3;
- case 3: fsr = 1;
+ case 2:
+ break;
+
+ case 1:
+ fsr = 3;
+ break;
+
+ case 3:
+ fsr = 1;
+ break;
}
rawfsr = _get_cw();
rawfsr |= (fsr << 10) | 0x3ff;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [commit/obvious] Fix PR sim/16018
2013-10-09 21:48 [commit/obvious] Fix PR sim/16018 Sergio Durigan Junior
@ 2013-10-10 2:23 ` Tom Tromey
2013-10-10 3:49 ` Sergio Durigan Junior
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2013-10-10 2:23 UTC (permalink / raw)
To: Sergio Durigan Junior; +Cc: GDB Patches
Sergio> In file included from ../../../../../gdb-src/sim/erc32/../../include/gdb/callback.h:55:0,
Sergio> from ../../../../../gdb-src/sim/erc32/sis.h:24,
Sergio> from ../../../../../gdb-src/sim/erc32/exec.c:23:
Sergio> ../../bfd/bfd.h:1070:48: error: unknown type name ‘size_t’
Sergio> Strange... I did not investigate too much, but maybe I'm doing
Sergio> something wrong.
This was a bug caused by my BFD patch yesterday.
I fixed it today.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [commit/obvious] Fix PR sim/16018
2013-10-10 2:23 ` Tom Tromey
@ 2013-10-10 3:49 ` Sergio Durigan Junior
0 siblings, 0 replies; 3+ messages in thread
From: Sergio Durigan Junior @ 2013-10-10 3:49 UTC (permalink / raw)
To: Tom Tromey; +Cc: GDB Patches
On Wednesday, October 09 2013, Tom Tromey wrote:
> Sergio> In file included from ../../../../../gdb-src/sim/erc32/../../include/gdb/callback.h:55:0,
> Sergio> from ../../../../../gdb-src/sim/erc32/sis.h:24,
> Sergio> from ../../../../../gdb-src/sim/erc32/exec.c:23:
> Sergio> ../../bfd/bfd.h:1070:48: error: unknown type name ‘size_t’
>
> Sergio> Strange... I did not investigate too much, but maybe I'm doing
> Sergio> something wrong.
>
> This was a bug caused by my BFD patch yesterday.
> I fixed it today.
Thanks Tom, it works OK now.
--
Sergio
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-10 3:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-09 21:48 [commit/obvious] Fix PR sim/16018 Sergio Durigan Junior
2013-10-10 2:23 ` Tom Tromey
2013-10-10 3:49 ` Sergio Durigan Junior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox