From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4353 invoked by alias); 9 Oct 2013 21:48:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4340 invoked by uid 89); 9 Oct 2013 21:48:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Oct 2013 21:48:07 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r99Lm5ae004650 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 9 Oct 2013 17:48:06 -0400 Received: from psique (ovpn-113-21.phx2.redhat.com [10.3.113.21]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r99Lm2iA002334 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Wed, 9 Oct 2013 17:48:04 -0400 From: Sergio Durigan Junior To: GDB Patches Subject: [commit/obvious] Fix PR sim/16018 X-URL: http://www.redhat.com Date: Wed, 09 Oct 2013 21:48:00 -0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00320.txt.bz2 Hi, I have committed the following patch as an obvious fix for PR sim/16018. It just adds missing "break" statements in a switch. I must confess that I did not manage to build ERC32 sim. What I did was: ../gdb-src/configure --target=3Dsparc-rtems4.11 --enable-sim --enable-sim= -hardware And I received the following error: In file included from ../../../../../gdb-src/sim/erc32/../../include/gdb/= callback.h:55:0, from ../../../../../gdb-src/sim/erc32/sis.h:24, from ../../../../../gdb-src/sim/erc32/exec.c:23: ../../bfd/bfd.h:1070:48: error: unknown type name =E2=80=98size_t=E2=80=99 Strange... I did not investigate too much, but maybe I'm doing something wrong. Anyway, patch applied. https://sourceware.org/ml/gdb-cvs/2013-10/msg00064.html --=20 Sergio 2013-10-09 Sergio Durigan Junior PR sim/16018: * float.c (set_fsr): Add missing "break" statements. Reindent code. diff --git a/sim/erc32/float.c b/sim/erc32/float.c index c1a46f8..1b8f0fc 100644 --- a/sim/erc32/float.c +++ b/sim/erc32/float.c @@ -91,9 +91,16 @@ uint32 fsr; fsr >>=3D 30; switch (fsr) { case 0:=20 - case 2: break; - case 1: fsr =3D 3; - case 3: fsr =3D 1; + case 2: + break; + + case 1: + fsr =3D 3; + break; + + case 3: + fsr =3D 1; + break; } rawfsr =3D _get_cw(); rawfsr |=3D (fsr << 10) | 0x3ff;