From: Sergio Durigan Junior <sergiodj@redhat.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: [commit/obvious] Fix PR sim/16018
Date: Wed, 09 Oct 2013 21:48:00 -0000 [thread overview]
Message-ID: <m3mwmiru99.fsf@redhat.com> (raw)
Hi,
I have committed the following patch as an obvious fix for PR
sim/16018. It just adds missing "break" statements in a switch.
I must confess that I did not manage to build ERC32 sim. What I did
was:
../gdb-src/configure --target=sparc-rtems4.11 --enable-sim --enable-sim-hardware
And I received the following error:
In file included from ../../../../../gdb-src/sim/erc32/../../include/gdb/callback.h:55:0,
from ../../../../../gdb-src/sim/erc32/sis.h:24,
from ../../../../../gdb-src/sim/erc32/exec.c:23:
../../bfd/bfd.h:1070:48: error: unknown type name ‘size_t’
Strange... I did not investigate too much, but maybe I'm doing
something wrong.
Anyway, patch applied.
https://sourceware.org/ml/gdb-cvs/2013-10/msg00064.html
--
Sergio
2013-10-09 Sergio Durigan Junior <sergiodj@redhat.com>
PR sim/16018:
* float.c (set_fsr): Add missing "break" statements. Reindent
code.
diff --git a/sim/erc32/float.c b/sim/erc32/float.c
index c1a46f8..1b8f0fc 100644
--- a/sim/erc32/float.c
+++ b/sim/erc32/float.c
@@ -91,9 +91,16 @@ uint32 fsr;
fsr >>= 30;
switch (fsr) {
case 0:
- case 2: break;
- case 1: fsr = 3;
- case 3: fsr = 1;
+ case 2:
+ break;
+
+ case 1:
+ fsr = 3;
+ break;
+
+ case 3:
+ fsr = 1;
+ break;
}
rawfsr = _get_cw();
rawfsr |= (fsr << 10) | 0x3ff;
next reply other threads:[~2013-10-09 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 21:48 Sergio Durigan Junior [this message]
2013-10-10 2:23 ` Tom Tromey
2013-10-10 3:49 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3mwmiru99.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox