From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org
Subject: Re: [RFC] Sort #includes in gdb
Date: Wed, 03 Apr 2019 20:11:00 -0000 [thread overview]
Message-ID: <87mul626ji.fsf@tromey.com> (raw)
In-Reply-To: <898eb4d9-9c21-9dee-0291-ce82251e6c42@redhat.com> (Pedro Alves's message of "Wed, 3 Apr 2019 20:00:40 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> On 03/29/2019 09:05 PM, Simon Marchi wrote:
>>
>> I don't think I've mentioned it, but I really like this change. I don't like the mental weight of having to choose where to add my include in an unorganized list :).
Pedro> Me too. I'm waiting for this to land before touching the "namespace gdb"
Pedro> work again, since a not-insignificant part of that work revolves around
Pedro> moving "#include"s in the middle of files to the top of the file.
This patch doesn't touch those includes -- it only touches the ones at
the top of a file. If you want to land yours first, it's no trouble for
me. The change is just running a script.
On irc the other day, Simon had the idea that I could land the patch in
pieces: say, convert [a-f]*, test that, check it in. I modified my
script to let me do this and the first batch went through. So, if you'd
really rather this go first, let me know and I can do it that way. It
may take a few days to get it all in.
Tom
next prev parent reply other threads:[~2019-04-03 20:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 15:40 Tom Tromey
2019-01-27 4:58 ` Joel Brobecker
2019-02-15 20:46 ` Tom Tromey
2019-01-28 19:08 ` Pedro Alves
2019-01-28 22:31 ` Matt Rice
2019-02-15 20:55 ` Tom Tromey
2019-03-15 23:13 ` Tom Tromey
2019-03-20 17:42 ` Pedro Alves
2019-03-29 20:52 ` Tom Tromey
2019-03-29 21:05 ` Simon Marchi
2019-03-30 18:35 ` Tom Tromey
2019-04-03 18:58 ` Pedro Alves
2019-04-03 19:29 ` Sergio Durigan Junior
2019-04-03 20:34 ` Sergio Durigan Junior
2019-04-04 2:47 ` Tom Tromey
2019-04-04 3:40 ` Sergio Durigan Junior
2019-04-03 19:00 ` Pedro Alves
2019-04-03 20:11 ` Tom Tromey [this message]
2019-04-03 21:00 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mul626ji.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox