From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFC] Sort #includes in gdb
Date: Fri, 15 Mar 2019 23:13:00 -0000 [thread overview]
Message-ID: <87r2b7viht.fsf@tromey.com> (raw)
In-Reply-To: <878sygydob.fsf@tromey.com> (Tom Tromey's message of "Fri, 15 Feb 2019 13:55:32 -0700")
Pedro> ISTR that you could point the bot at some branch instead of a patch?
Tom> I don't know but I will ask Sergio when he's back.
I think it can't be done.
Pedro> No firm opinion on comments vs no comments.
Tom> For now at least, I'm sticking with "no comments" because the lack of
Tom> comment-handling in the script means that adding comments makes the
Tom> script non-idempotent. But, idempotency is a good quality to have,
Tom> because it means the script can be re-run at any time to fix any
Tom> "regressions" that have crept in.
I thought about this some more and I went back and implemented limited
comment-scanning, to make this work. I think this is nicer because it
provides an in-source guide to developers saying where to add a new
#include.
I've appended the relevant bits from the rewritten objfiles.c.
Let me know what you think.
Tom
#include "defs.h"
#include "objfiles.h"
/* Standard C includes. */
#include <fcntl.h>
#include <sys/stat.h>
#include <sys/types.h>
/* Standard C++ includes. */
#include <vector>
/* Local non-gdb includes. */
#include "bfd.h"
#include "hashtab.h"
/* Local subdirectory includes. */
#include "common/pathstuff.h"
/* Local includes. */
#include "addrmap.h"
#include "arch-utils.h"
#include "bcache.h"
#include "block.h"
#include "breakpoint.h"
#include "btrace.h"
#include "complaints.h"
#include "dictionary.h"
#include "exec.h"
#include "expression.h"
#include "gdb-stabs.h"
#include "gdb_bfd.h"
#include "gdb_obstack.h"
#include "observable.h"
#include "parser-defs.h"
#include "psymtab.h"
#include "solist.h"
#include "source.h"
#include "symfile.h"
#include "symtab.h"
#include "target.h"
next prev parent reply other threads:[~2019-03-15 23:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-26 15:40 Tom Tromey
2019-01-27 4:58 ` Joel Brobecker
2019-02-15 20:46 ` Tom Tromey
2019-01-28 19:08 ` Pedro Alves
2019-01-28 22:31 ` Matt Rice
2019-02-15 20:55 ` Tom Tromey
2019-03-15 23:13 ` Tom Tromey [this message]
2019-03-20 17:42 ` Pedro Alves
2019-03-29 20:52 ` Tom Tromey
2019-03-29 21:05 ` Simon Marchi
2019-03-30 18:35 ` Tom Tromey
2019-04-03 18:58 ` Pedro Alves
2019-04-03 19:29 ` Sergio Durigan Junior
2019-04-03 20:34 ` Sergio Durigan Junior
2019-04-04 2:47 ` Tom Tromey
2019-04-04 3:40 ` Sergio Durigan Junior
2019-04-03 19:00 ` Pedro Alves
2019-04-03 20:11 ` Tom Tromey
2019-04-03 21:00 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2b7viht.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox