From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49972 invoked by alias); 3 Apr 2019 20:11:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49951 invoked by uid 89); 3 Apr 2019 20:11:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=yours X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Apr 2019 20:11:17 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway31.websitewelcome.com (Postfix) with ESMTP id BEE53471CF for ; Wed, 3 Apr 2019 15:11:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id BmE7heknS2PzOBmE7hGHcg; Wed, 03 Apr 2019 15:11:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=C76reEIn80bQDK1QKREARylO5m0saC7QM/c09ax4cps=; b=rEj4Jb+DC8o6mXR30lcMXYylQS 0MWSKz5itsCr8jPUIpQ2b0pYT0vx9JvcHuTvFoUhkkbqebGIe5lxmZ2v5ppxvChuBs5oLreFRBEmr SC3ycpeKUu4fU6gx5nAguhudt; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:42686 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hBmE7-0035M7-Dd; Wed, 03 Apr 2019 15:11:15 -0500 From: Tom Tromey To: Pedro Alves Cc: Simon Marchi , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC] Sort #includes in gdb References: <87fttfmnpq.fsf@tromey.com> <878sygydob.fsf@tromey.com> <87r2b7viht.fsf@tromey.com> <875zs1csim.fsf@tromey.com> <898eb4d9-9c21-9dee-0291-ce82251e6c42@redhat.com> Date: Wed, 03 Apr 2019 20:11:00 -0000 In-Reply-To: <898eb4d9-9c21-9dee-0291-ce82251e6c42@redhat.com> (Pedro Alves's message of "Wed, 3 Apr 2019 20:00:40 +0100") Message-ID: <87mul626ji.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-04/txt/msg00061.txt.bz2 >>>>> "Pedro" =3D=3D Pedro Alves writes: Pedro> On 03/29/2019 09:05 PM, Simon Marchi wrote: >>=20 >> I don't think I've mentioned it, but I really like this change.=C2=A0 I = don't like the mental weight of having to choose where to add my include in= an unorganized=C2=A0list=C2=A0:). Pedro> Me too. I'm waiting for this to land before touching the "namespace= gdb" Pedro> work again, since a not-insignificant part of that work revolves aro= und Pedro> moving "#include"s in the middle of files to the top of the file. This patch doesn't touch those includes -- it only touches the ones at the top of a file. If you want to land yours first, it's no trouble for me. The change is just running a script. On irc the other day, Simon had the idea that I could land the patch in pieces: say, convert [a-f]*, test that, check it in. I modified my script to let me do this and the first batch went through. So, if you'd really rather this go first, let me know and I can do it that way. It may take a few days to get it all in. Tom