From: Tom Tromey <tom@tromey.com>
To: Kamil Rytarowski <n54@gmx.com>
Cc: gdb-patches@sourceware.org, jhb@FreeBSD.org, tom@tromey.com
Subject: Re: [PATCH v2 1/2] gdb: Implement native dumpcore function
Date: Wed, 05 Aug 2020 10:23:50 -0600 [thread overview]
Message-ID: <87mu39njs9.fsf@tromey.com> (raw)
In-Reply-To: <20200728154602.3824-1-n54@gmx.com> (Kamil Rytarowski's message of "Tue, 28 Jul 2020 17:46:01 +0200")
>>>>> "Kamil" == Kamil Rytarowski <n54@gmx.com> writes:
Kamil> Add new API for systems with native kernel support for dumping
Kamil> a process on demand. Wire it into the gdb's gcore functionality.
Kamil> gdb/ChangeLog:
Kamil> * target.h (supports_native_dumpcore, native_dumpcore): New
Kamil> function declarations.
Kamil> * target.c (supports_native_dumpcore, native_dumpcore): New
Kamil> functions.
Kamil> * target-delegates.c: Rebuild.
Kamil> * gcore.c (gcore_command): Use target_supports_native_dumpcore ()
Kamil> and target_native_dumpcore ().
Thank you for the patch.
Kamil> + /* Generate the core file with native target API. */
Kamil> + virtual bool dumpcore (const char *filename)
Kamil> + TARGET_DEFAULT_RETURN (false);
There doesn't seem to be a reason to have a bool return here.
The value isn't documented or used.
Tom
next prev parent reply other threads:[~2020-08-05 16:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 14:43 [PATCH] " Kamil Rytarowski
2020-07-27 15:47 ` John Baldwin
2020-07-27 21:09 ` Tom Tromey
2020-07-28 15:46 ` [PATCH v2 1/2] " Kamil Rytarowski
2020-07-28 15:46 ` [PATCH v2 2/2] gdb: Implement native dumpcore function for NetBSD Kamil Rytarowski
2020-08-05 16:24 ` Tom Tromey
2020-08-13 17:16 ` Kamil Rytarowski
2020-07-28 18:56 ` [PATCH v2 1/2] gdb: Implement native dumpcore function Christian Biesinger
2020-07-28 20:39 ` Kamil Rytarowski
2020-07-29 15:45 ` Tom Tromey
2020-08-05 16:23 ` Tom Tromey [this message]
2020-08-13 17:15 ` Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu39njs9.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=n54@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox