From: Kamil Rytarowski <n54@gmx.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, jhb@FreeBSD.org
Subject: Re: [PATCH v2 2/2] gdb: Implement native dumpcore function for NetBSD
Date: Thu, 13 Aug 2020 19:16:41 +0200 [thread overview]
Message-ID: <72839834-fd4e-42b1-1c13-4ac7c4bbd357@gmx.com> (raw)
In-Reply-To: <87imdxnjqo.fsf@tromey.com>
On 05.08.2020 18:24, Tom Tromey wrote:
>>>>>> "Kamil" == Kamil Rytarowski <n54@gmx.com> writes:
>
> Kamil> Define supports_dumpcore and dumpcore for NetBSD, that wraps
> Kamil> the ptrace(2) call with the PT_DUMPCORE operation.
>
> Kamil> + return ptrace (PT_DUMPCORE, pid, const_cast<char *>(filename),
> Kamil> + strlen (filename)) != -1;
>
> If this can fail it is probably better to call perror_with_name or
> error or something along those lines.
>
I've switched to perror_with_name in v3 and I have checked that it can
fail and be handled gracefully.
> Tom
>
next prev parent reply other threads:[~2020-08-13 17:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 14:43 [PATCH] gdb: Implement native dumpcore function Kamil Rytarowski
2020-07-27 15:47 ` John Baldwin
2020-07-27 21:09 ` Tom Tromey
2020-07-28 15:46 ` [PATCH v2 1/2] " Kamil Rytarowski
2020-07-28 15:46 ` [PATCH v2 2/2] gdb: Implement native dumpcore function for NetBSD Kamil Rytarowski
2020-08-05 16:24 ` Tom Tromey
2020-08-13 17:16 ` Kamil Rytarowski [this message]
2020-07-28 18:56 ` [PATCH v2 1/2] gdb: Implement native dumpcore function Christian Biesinger
2020-07-28 20:39 ` Kamil Rytarowski
2020-07-29 15:45 ` Tom Tromey
2020-08-05 16:23 ` Tom Tromey
2020-08-13 17:15 ` Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72839834-fd4e-42b1-1c13-4ac7c4bbd357@gmx.com \
--to=n54@gmx.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox