From: Tom Tromey <tom@tromey.com>
To: Kamil Rytarowski <n54@gmx.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Implement native dumpcore function
Date: Mon, 27 Jul 2020 15:09:09 -0600 [thread overview]
Message-ID: <87h7tsacne.fsf@tromey.com> (raw)
In-Reply-To: <20200727144338.7033-1-n54@gmx.com> (Kamil Rytarowski's message of "Mon, 27 Jul 2020 16:43:38 +0200")
>>>>> "Kamil" == Kamil Rytarowski <n54@gmx.com> writes:
Kamil> +bool
Kamil> +nbsd_nat_target::native_dumpcore (char *filename)
Should be "const char *".
Kamil> +{
Kamil> + pid_t pid = inferior_ptid.pid ();
Kamil> +
Kamil> + return ptrace(PT_DUMPCORE, pid, filename, strlen(filename)) != -1;
Spaces before parens in the gdb style.
I wonder if it makes sense to just always defer to the target, and then
have the default target method be a function implementing the existing
approach. I'm not sure either way, but I thought I'd throw the idea out
there.
Tom
next prev parent reply other threads:[~2020-07-27 21:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 14:43 Kamil Rytarowski
2020-07-27 15:47 ` John Baldwin
2020-07-27 21:09 ` Tom Tromey [this message]
2020-07-28 15:46 ` [PATCH v2 1/2] " Kamil Rytarowski
2020-07-28 15:46 ` [PATCH v2 2/2] gdb: Implement native dumpcore function for NetBSD Kamil Rytarowski
2020-08-05 16:24 ` Tom Tromey
2020-08-13 17:16 ` Kamil Rytarowski
2020-07-28 18:56 ` [PATCH v2 1/2] gdb: Implement native dumpcore function Christian Biesinger
2020-07-28 20:39 ` Kamil Rytarowski
2020-07-29 15:45 ` Tom Tromey
2020-08-05 16:23 ` Tom Tromey
2020-08-13 17:15 ` Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7tsacne.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=n54@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox