From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id 2A2DF3857C5B for ; Thu, 13 Aug 2020 17:19:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2A2DF3857C5B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1597339151; bh=XPawIbjnUj+E/0JYADOa1Eunv+VFUpDVjT+pIlkpMMM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=KvGSRgQkn5F4KO/ka71U0OTRHkZz7X0F2APTQD4LvXT/oqV4MuZJY0KRvT0IofYO0 IFbd0IkCZEWL5wkoev7mzzbUiQzMSOpZsAV6Ta2MG+IHTrVYkPOZ5m1lL51kEGxLR3 nozUqL8rvoG75LMK05y9Z9clvTvxv1XUlmgMVD+Q= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mlw3X-1kX2zc0mKB-00j5Wk; Thu, 13 Aug 2020 19:19:11 +0200 Subject: Re: [PATCH v2 2/2] gdb: Implement native dumpcore function for NetBSD To: Tom Tromey Cc: gdb-patches@sourceware.org, jhb@FreeBSD.org References: <20200727144338.7033-1-n54@gmx.com> <20200728154602.3824-1-n54@gmx.com> <20200728154602.3824-2-n54@gmx.com> <87imdxnjqo.fsf@tromey.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: <72839834-fd4e-42b1-1c13-4ac7c4bbd357@gmx.com> Date: Thu, 13 Aug 2020 19:16:41 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87imdxnjqo.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:wBuZpqt+LvJ4OQga6IHFx7eAGe47m2NA33qgNJWVRIRFVuDT54j DSelirmiCgTQr1fiKsRJr268X6lixcVucuvKHtfdT/KB4uuxlr5QqqqpAV1BRXYM13MKZOz fa9Rxno5tSK54oc27wI3rXJ5lWcIUJbOM6V8bLn0kw/+HYu6Q1lpN5rzlsmjl4jDb3hBie5 uk60tHLOWWaGElsGlJTcw== X-UI-Out-Filterresults: notjunk:1;V03:K0:nOj4vOFQeuE=:weChUtBpsITqkPJkVq8z8O mLTATUU0BuUceKn/G0tRYjPIgIOpTQfLQk81Cgq9vjIXPG8fb3HiTC3Ez9xthZ2nVTkMJw1Ky 6d4Huh6aRMKBZ98iih+vtp+9JXk1tt8RRofsxd+X48ig9nMmgQpZRVqjdn/28mNuk26j1raiM PkOYFRijuTrbOszyMoya8QwNIY7kyq2n/GG++wjpM5/PE3KLJ0ec4P9uwrpcuQuKrtRcQbclj zW0z6yIZO9wb116l9GtfOGRUBRQUDG+0ciiG3maxg0IGASoqQ+XLM+Pv//MVbJda1h+yph4FY Iq1kniSv7VChhd80KhX6hir6vFUpiB28yZEjeaCgnGn/0Jml/OiRwPzzMlTpq3ajx1GFYO7A1 GVp3u0bMMJ7RcoV6MqLq/ihmHDi45co5ZaBN5WWt/YrOfuBq+yozvvIZMTCO+n86U3gluf/Ct 8yyXc/NejD/GZJCWeYdBkqKMOtKshxKG4NyXt3yD1f4Dj1wAyqWI2ve+WIbhT2MyXmLI+Tiz/ 3T5g9OI0CJcwJUUWNt9XdeCQdjbyTwOZUM8OSLdV6O2RsqYRLA8PoaqH5m+1PZA9HhQDZu6s0 wysXdtzyAWwYnyNarZ5sqCW9UxjBALVBagw9ZgNMc6zFHtaK910icxWxeyTr1uyL6SUIOxphq X+A8nMvaSOGLJn0I5q5uMcDAvCtQNypHTgA949UEMGenioo9+GoJP0KAo0Upe+QfanZ86jBHw /IgH0Y20ZSwCU9nbSnO/Q+tOcN/J2tYYx7y5oq5XlxOMsbSJ/SxpUPkMlSdM+p3uQoYn4w2Yl EKjAGXatd8r8Sc5pVAMNa/du0IvQ03nk42kpHW52kErZdPB4MT/Hk/xzXuk4baRG9cXLB61+1 7UyqgjXZRKydCudkzI81dL7th3Jr2h0Xt3wWQ9r2/6XPVKS1QGbDX0Tz9CuwTGKerK/ktF2+P Cr/TJl7YtsEaHM/fTo9gioC8Iqg64wxaqRRF+U51nN0K2G/EAzycjBha3ErYPYMlUxTM00PM3 ZpvTN3LMGMFUDGMYFAQVKFBd5FGKa0T/rc368wjFV3zc6beRwAUPWrfbNBADJgt8QCM4ZbTqH PE6Q45ttkC4T9ZNaGD1XiswV8h24pXiHrPVrAC8f5WF1HJX24PhZHa61L4oXoK9RNsaHbBxim 9f6W/Cz73NV533zMhm7cYSLf5JBY9VNvTZDQgs7svJirJfO4RscKqAz/ZOV7GvNdSqxtWEKMQ O4mPlS6cG0lE5Xit1 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2020 17:19:28 -0000 On 05.08.2020 18:24, Tom Tromey wrote: >>>>>> "Kamil" =3D=3D Kamil Rytarowski writes: > > Kamil> Define supports_dumpcore and dumpcore for NetBSD, that wraps > Kamil> the ptrace(2) call with the PT_DUMPCORE operation. > > Kamil> + return ptrace (PT_DUMPCORE, pid, const_cast(filename), > Kamil> + strlen (filename)) !=3D -1; > > If this can fail it is probably better to call perror_with_name or > error or something along those lines. > I've switched to perror_with_name in v3 and I have checked that it can fail and be handled gracefully. > Tom >