From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.109]) by sourceware.org (Postfix) with ESMTPS id 1A2BF3857008 for ; Wed, 5 Aug 2020 16:24:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1A2BF3857008 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway34.websitewelcome.com (Postfix) with ESMTP id F149DAD055 for ; Wed, 5 Aug 2020 11:23:52 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 3MCmkqOHMXp2A3MCmkIAyD; Wed, 05 Aug 2020 11:23:52 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=u9zQA4WpelcpCTtpPVOwUIBGrnTlHNkR0cSV+pUjkZ8=; b=WloTE8f/XpbNf5jtZS0Wy8y1LN Ky0bORGnIl110CS+G5UfyAgZVeAizUDfqGY1pC65rqITnfHMA25/a16iv7se8VJbjzBzEHL8FoeRj RN+zBxNJAd1fKcK4QtGLSfW5B; Received: from 75-166-101-103.hlrn.qwest.net ([75.166.101.103]:34938 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1k3MCm-00270G-Kb; Wed, 05 Aug 2020 10:23:52 -0600 From: Tom Tromey To: Kamil Rytarowski Cc: gdb-patches@sourceware.org, jhb@FreeBSD.org, tom@tromey.com Subject: Re: [PATCH v2 1/2] gdb: Implement native dumpcore function References: <20200727144338.7033-1-n54@gmx.com> <20200728154602.3824-1-n54@gmx.com> X-Attribution: Tom Date: Wed, 05 Aug 2020 10:23:50 -0600 In-Reply-To: <20200728154602.3824-1-n54@gmx.com> (Kamil Rytarowski's message of "Tue, 28 Jul 2020 17:46:01 +0200") Message-ID: <87mu39njs9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.101.103 X-Source-L: No X-Exim-ID: 1k3MCm-00270G-Kb X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-101-103.hlrn.qwest.net (murgatroyd) [75.166.101.103]:34938 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2020 16:24:16 -0000 >>>>> "Kamil" == Kamil Rytarowski writes: Kamil> Add new API for systems with native kernel support for dumping Kamil> a process on demand. Wire it into the gdb's gcore functionality. Kamil> gdb/ChangeLog: Kamil> * target.h (supports_native_dumpcore, native_dumpcore): New Kamil> function declarations. Kamil> * target.c (supports_native_dumpcore, native_dumpcore): New Kamil> functions. Kamil> * target-delegates.c: Rebuild. Kamil> * gcore.c (gcore_command): Use target_supports_native_dumpcore () Kamil> and target_native_dumpcore (). Thank you for the patch. Kamil> + /* Generate the core file with native target API. */ Kamil> + virtual bool dumpcore (const char *filename) Kamil> + TARGET_DEFAULT_RETURN (false); There doesn't seem to be a reason to have a bool return here. The value isn't documented or used. Tom