Re: [PATCH v2 10/11] gdb: change some pointers to references in global_symbol_searcher

[Andrew Burgess <aburgess@redhat.com>]

simon.marchi@polymtl.ca writes:

> From: Simon Marchi <simon.marchi@efficios.com>
>
> add_matching_symbols and add_matching_msymbols take the container to
> add results to as a pointer, but it can never be nullptr.  Pass it by
> reference instead.
>
> The objfiles are also passed by pointer to the various helper methods,
> switch that to references.
>
> Change-Id: I65d8e14f2f3152d83afbe3b348fc91a8817b87fa
> ---
>  gdb/symtab.c | 39 +++++++++++++++++++--------------------
>  gdb/symtab.h | 10 +++++-----
>  2 files changed, 24 insertions(+), 25 deletions(-)
>
> diff --git a/gdb/symtab.c b/gdb/symtab.c
> index ef21f285abcd..af748190ddd5 100644
> --- a/gdb/symtab.c
> +++ b/gdb/symtab.c

> @@ -4945,16 +4945,16 @@ global_symbol_searcher::add_matching_msymbols
>  	 symbol might be found via find_pc_symtab.  */
>        if (m_kind == symbol_search_kind::FUNCTION
>  	  && (find_compunit_symtab_for_pc
> -	      (msymbol->value_address (objfile)) != NULL))
> +	      (msymbol->value_address (&objfile)) != NULL))
>  	continue;
>  
>        if (lookup_symbol_in_objfile_from_linkage_name
> -	    (objfile, msymbol->linkage_name (), SEARCH_VFT).symbol != NULL)
> +	    (&objfile, msymbol->linkage_name (), SEARCH_VFT).symbol != NULL)
>  	continue;

Two lines above here can replace NULL with nullptr.

With that done:

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew