Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: simon.marchi@polymtl.ca
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH v2 00/11] Cleanups in global_symbol_searcher
Date: Wed, 30 Sep 2026 22:09:17 -0400	[thread overview]
Message-ID: <20261001020952.698419-1-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <20260929194119.155169-1-simon.marchi@efficios.com>

From: Simon Marchi <simon.marchi@polymtl.ca>

This is v2 of:

  https://inbox.sourceware.org/gdb-patches/20260929194119.155169-1-simon.marchi@efficios.com/T/#m02147ed61720d62b82a7514f72c29f3863ca046d

where I address most of Stephan's comments.

There are 2 new patches:

 - I split the preg/treg renaming in its own patch
 - I added one patch to make stack.c re-use a function from symtab.c to
   compile the symbol search regex

Simon Marchi (11):
  gdb: add symbol_search_kind enum for global_symbol_searcher
  gdb: rename some preg/treg variables
  gdb: factor out regexp compilation from global_symbol_searcher::search
  gdb: use compile_symbol_search_regex in stack.c
  gdb: simplify insertion in
    global_symbol_searcher::add_matching_symbols
  gdb: use a switch on m_kind in add_matching_symbols
  gdb: make global_symbol_searcher::is_suitable_msymbol non-static
  gdb: update comments of global_symbol_searcher::expand_symtabs
  gdb: add matching helpers to global_symbol_searcher
  gdb: change some pointers to references in global_symbol_searcher
  gdb: fix some comments in global_symbol_searcher

 gdb/mi/mi-symbol-cmds.c |  36 +--
 gdb/python/python.c     |   2 +-
 gdb/stack.c             |  63 ++----
 gdb/symtab.c            | 471 ++++++++++++++++++++++------------------
 gdb/symtab.h            | 137 ++++++++----
 5 files changed, 401 insertions(+), 308 deletions(-)


base-commit: 8eeaa4ee84d3b590321f7a3595a3c7ba8da31a11
-- 
2.55.0


  parent reply	other threads:[~2026-10-01  2:10 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 19:39 [PATCH 0/9] " Simon Marchi
2026-09-29 19:39 ` [PATCH 1/9] gdb: add symbol_search_kind enum for global_symbol_searcher Simon Marchi
2026-09-30  9:31   ` Rohr, Stephan
2026-09-30 14:50     ` Simon Marchi
2026-09-29 19:39 ` [PATCH 2/9] gdb: factor out regexp compilation from global_symbol_searcher::search Simon Marchi
2026-09-30 12:10   ` Rohr, Stephan
2026-09-30 16:21     ` Simon Marchi
2026-09-29 19:39 ` [PATCH 3/9] gdb: simplify insertion in global_symbol_searcher::add_matching_symbols Simon Marchi
2026-09-30  8:20   ` Rohr, Stephan
2026-09-30 16:36     ` Simon Marchi
2026-09-29 19:39 ` [PATCH 4/9] gdb: use a switch on m_kind in add_matching_symbols Simon Marchi
     [not found]   ` <DS7PR11MB624725508FC878F3C263C2B3938B2@DS7PR11MB6247.namprd11.prod.outlook.com>
2026-09-30 19:41     ` Simon Marchi
2026-09-29 19:39 ` [PATCH 5/9] gdb: make global_symbol_searcher::is_suitable_msymbol non-static Simon Marchi
2026-09-30 12:39   ` Rohr, Stephan
2026-09-29 19:39 ` [PATCH 6/9] gdb: update comment of global_symbol_searcher::expand_symtabs Simon Marchi
2026-09-30 13:08   ` Rohr, Stephan
2026-09-30 20:01     ` Simon Marchi
2026-09-29 19:39 ` [PATCH 7/9] gdb: add matching helpers to global_symbol_searcher Simon Marchi
2026-09-30 13:51   ` Rohr, Stephan
2026-09-30 20:27     ` Simon Marchi
2026-09-29 19:39 ` [PATCH 8/9] gdb: pass result containers by reference in global_symbol_searcher Simon Marchi
2026-09-30 13:58   ` Rohr, Stephan
2026-10-01  1:33     ` Simon Marchi
2026-09-29 19:39 ` [PATCH 9/9] gdb: fix some comments " Simon Marchi
2026-09-30 14:01   ` Rohr, Stephan
2026-10-01  1:38     ` Simon Marchi
2026-10-01  2:09 ` simon.marchi [this message]
2026-10-01  2:09 ` [PATCH v2 01/11] gdb: add symbol_search_kind enum for global_symbol_searcher simon.marchi
2026-10-01 10:30   ` Andrew Burgess
2026-10-01 13:22     ` Simon Marchi
2026-10-01 15:35       ` Tom Tromey
2026-10-01  2:09 ` [PATCH v2 02/11] gdb: rename some preg/treg variables simon.marchi
2026-10-01 12:59   ` Andrew Burgess
2026-10-01 13:52     ` Simon Marchi
2026-10-01  2:09 ` [PATCH v2 03/11] gdb: factor out regexp compilation from global_symbol_searcher::search simon.marchi
2026-10-01 13:19   ` Andrew Burgess
2026-10-01 13:54     ` Simon Marchi
2026-10-01  2:09 ` [PATCH v2 04/11] gdb: use compile_symbol_search_regex in stack.c simon.marchi
2026-10-01 13:43   ` Andrew Burgess
2026-10-01 15:36   ` Tom Tromey
2026-10-01 15:52     ` Simon Marchi
2026-10-01  2:09 ` [PATCH v2 05/11] gdb: simplify insertion in global_symbol_searcher::add_matching_symbols simon.marchi
2026-10-01 13:46   ` Andrew Burgess
2026-10-01  2:09 ` [PATCH v2 06/11] gdb: use a switch on m_kind in add_matching_symbols simon.marchi
2026-10-01 15:01   ` Andrew Burgess
2026-10-01 15:07     ` Simon Marchi
2026-10-01  2:09 ` [PATCH v2 07/11] gdb: make global_symbol_searcher::is_suitable_msymbol non-static simon.marchi
2026-10-01 15:09   ` Andrew Burgess
2026-10-01  2:09 ` [PATCH v2 08/11] gdb: update comments of global_symbol_searcher::expand_symtabs simon.marchi
2026-10-01 15:13   ` Andrew Burgess
2026-10-01  2:09 ` [PATCH v2 09/11] gdb: add matching helpers to global_symbol_searcher simon.marchi
2026-10-01 15:39   ` Andrew Burgess
2026-10-01 15:48     ` Simon Marchi
2026-10-01  2:09 ` [PATCH v2 10/11] gdb: change some pointers to references in global_symbol_searcher simon.marchi
2026-10-01 15:53   ` Andrew Burgess
2026-10-01 15:55     ` Simon Marchi
2026-10-01  2:09 ` [PATCH v2 11/11] gdb: fix some comments " simon.marchi
2026-10-01 15:56   ` Andrew Burgess
2026-10-01 17:47     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261001020952.698419-1-simon.marchi@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox