From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iYkrOxzBvWryTCEAWB0awg (envelope-from ) for ; Wed, 30 Sep 2026 22:10:36 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=EZALht1X; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EB4031E051; Wed, 30 Sep 2026 22:10:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 97D4F1E033 for ; Wed, 30 Sep 2026 22:10:36 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3C5E94BB58F5 for ; Thu, 1 Oct 2026 02:10:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3C5E94BB58F5 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=EZALht1X Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7ABB54BB1C24 for ; Thu, 1 Oct 2026 02:10:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7ABB54BB1C24 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7ABB54BB1C24 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790820601; cv=none; b=CigwIzoDWm16f7q+Dvss+Cgcv3C7Il6LslwvLLfSzbYJcCKt4elT82D6BL/ukljcBvFd1RZZLSc2EsVUH3H4DLAaKnxvpaaehP8oWw9tTXby8SqZCtuL+THzAYqsvsvHH6rXqiGrjzMnnSKql2fyQchtu3ExBJdIy1MEUskRXug= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790820601; c=relaxed/simple; bh=YaZSoQeTs39kV19ka+/zqorcVNPd6tcZPBi4AegNm9Y=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JA7LhCDjzIPyMNVdawlLZMlvG4M3k761YdswQKUkZ4b8liUAo6VV96dPQxBXcuRr5unS+2DIre5wm5MSPE+3c2BeytjOAMSlqKwJ72Svgm348IPG+QkTtjOvw2MdtsJMb3fdu0X7oUzACiFoue6mfQym6toT0lDvSpAc2YiQLns= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=EZALht1X DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7ABB54BB1C24 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 69129sHl167671 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Sep 2026 22:09:58 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 69129sHl167671 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1790820599; bh=DjmMB169x80EYKrmSSXHEdARL0duYpnqBtZyvLfFeo4=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=EZALht1Xu8xKTKUO2EXsBnQTFAxG0uKVH1J0Qua/lzuxAmaDHw1ZQE7juRQgmL0C5 jImYH7rpdYbD62EUOhomX7/fUVBOB3Vx4TNjXqUxZ26qvl08DLvlpwKnhPfwAveu4o sPQ2DZivfV3YK/hhFaYV8xNmZNuaSbtpWSG6gc0RAPTBfvp3om3nJqWu51BSRmyVBr FEAZHiFu3umG/+4/AMj4FIW747l9ii+aYwZx66cWK8C5jtFojs+dx2rd1/P/UIPpdm /g4SjSnJ3YUXRJLMeqqqZGcPsRccE6Q14z642FsOGP472l5A3CTopCVnaJN2E2Owk6 TuvPNrcG4a3Fg== Received: by simark.ca (Postfix) id E6BDB1E033; Wed, 30 Sep 2026 22:09:53 -0400 (EDT) From: simon.marchi@polymtl.ca To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH v2 00/11] Cleanups in global_symbol_searcher Date: Wed, 30 Sep 2026 22:09:17 -0400 Message-ID: <20261001020952.698419-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260929194119.155169-1-simon.marchi@efficios.com> References: <20260929194119.155169-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 1 Oct 2026 02:09:54 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: Simon Marchi This is v2 of: https://inbox.sourceware.org/gdb-patches/20260929194119.155169-1-simon.marchi@efficios.com/T/#m02147ed61720d62b82a7514f72c29f3863ca046d where I address most of Stephan's comments. There are 2 new patches: - I split the preg/treg renaming in its own patch - I added one patch to make stack.c re-use a function from symtab.c to compile the symbol search regex Simon Marchi (11): gdb: add symbol_search_kind enum for global_symbol_searcher gdb: rename some preg/treg variables gdb: factor out regexp compilation from global_symbol_searcher::search gdb: use compile_symbol_search_regex in stack.c gdb: simplify insertion in global_symbol_searcher::add_matching_symbols gdb: use a switch on m_kind in add_matching_symbols gdb: make global_symbol_searcher::is_suitable_msymbol non-static gdb: update comments of global_symbol_searcher::expand_symtabs gdb: add matching helpers to global_symbol_searcher gdb: change some pointers to references in global_symbol_searcher gdb: fix some comments in global_symbol_searcher gdb/mi/mi-symbol-cmds.c | 36 +-- gdb/python/python.c | 2 +- gdb/stack.c | 63 ++---- gdb/symtab.c | 471 ++++++++++++++++++++++------------------ gdb/symtab.h | 137 ++++++++---- 5 files changed, 401 insertions(+), 308 deletions(-) base-commit: 8eeaa4ee84d3b590321f7a3595a3c7ba8da31a11 -- 2.55.0