Re: [PATCH 6/9] gdb: update comment of global_symbol_searcher::expand_symtabs

[Simon Marchi <simon.marchi@efficios.com>]

On 2026-09-30 09:08, Rohr, Stephan wrote:
>> diff --git a/gdb/symtab.h b/gdb/symtab.h
>> index 50d7000681df..acbe41d131b7 100644
>> --- a/gdb/symtab.h
>> +++ b/gdb/symtab.h
>> @@ -2676,8 +2676,9 @@ class global_symbol_searcher
>>    std::optional<compiled_regex> compile_type_regex () const;
>>
>>    /* Expand symtabs in OBJFILE that match NAME_REGEX, are of type
>> M_KIND.
>> -     Return true if any msymbols were seen that we should later consider
>> -     adding to the results list.  */
>> +     Return true if a matching function msymbol without debug info was
>> +     seen, meaning that msymbols should later be considered for the results
>> +     list.  */
> 
> If we update comment, what about updating the first sentence to
> 
> "Expand symtabs in OBJFILE that match NAME_REGEX and are of type M_KIND."
> 
> This reads better from my point of view.

Agreed, fixed.

> I was also wondering if it's worth updating the comments inside the "expand_symtabs"
> function:
> 
>   - [..] When no file names were given the caller unconditionally rescans [..]
> 
>      The "unconditionally" can be dropped.  It is gated in "search ()".

I'll do that.  Honestly, I'm not even sure what this part of the comment
brings.


> - The comment this contains "SEARCH_VAR_DOMAIN".  Should this be changed to
>    "symbol_search_kind:: VARIABLE" instead?  Not sure if this is the right patch for this
>    change.

I'll just say "for variables".

Simon