From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GZVRCMpqvWq6+h8AWB0awg (envelope-from ) for ; Wed, 30 Sep 2026 16:02:18 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=tk4sI8rV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id ECF381E01F; Wed, 30 Sep 2026 16:02:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 489001E01F for ; Wed, 30 Sep 2026 16:02:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EFD834BB3B93 for ; Wed, 30 Sep 2026 20:02:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFD834BB3B93 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=tk4sI8rV Received: from YT5PR01CU002.outbound.protection.outlook.com (mail-canadacentralazon11021119.outbound.protection.outlook.com [40.107.192.119]) by sourceware.org (Postfix) with ESMTPS id 799524BB3BCF for ; Wed, 30 Sep 2026 20:01:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 799524BB3BCF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 799524BB3BCF Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=40.107.192.119 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1790798510; cv=pass; b=kS2ks4oW0anhDZYqb3TioFgqXc3avgi3bUbLZnWAEnRPgMfvtbITAz+HExcQSc6vufnhx2ajViToADerbieKR08BfagWkNIo1V1s2cOIbjlEObm3sTUEbCQbCZCmaR3WL95A2mrCZOxxQHxzwhZmedKBpnD+Ln38A1rHdrCrqPs= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1790798510; c=relaxed/simple; bh=elz5MBba/4TSyJe//75bfsaKMv9lh//gwKWpkxMgMvM=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=PprRI8TBussoLZVH69bCmyfaWtJeZivDrX/BcBpTBkR1INci+ZLmPd/8th0ATT1UERiYfM4fPNBZKdsRqiSr+OAIVhM7WTOL8mrQqxVatj2vtPbCQ2g14hrZ8rCI9lGwpDwOw67ceWNByNjazpCjpJp9PYM0PRqSQ9v/6LAmOjE= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=tk4sI8rV DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 799524BB3BCF ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=deyIoJmn0piYVYXsvvX6cDRDZCTKkqrnH+rJM1IUT4/CNMyzzdz876SjA18Z4mnlTetJ5xSH0sOjswvIsfqQu9+ks1w7mu9fJOy16y5aPi/KBfujHqVQOA3NN+mvqVGAxZwQyzW9i9z8D9HJptB/d/b/y5NnVyVj6oqJFMArBVb4igfIQGIylx8TSESRfFRwarapOA7qeI2CvUXXo2vB3pWnFIUAt/oKvP2nMirjwQEQmaF+PSyTvJmlmxW/eH/Wfxn6gRDhb0/NDbQdloFTwSrZw+ZBQHrDTg6Mpga/cK/vLXozF3u+CUAcO5WdNid614aSekVwQwP1PFFSR7k85g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rZ9rKprFQngGmhxXk2l57/sPYWya2/ZnBggR9c6xVP0=; b=MYXIklZFcczlp76rZN9NjFpJiCsO+NjZtJXikhCy09Olmd81e9RwCjjJbVaI3yDC1pA8jMgxGDXD32NTZvQvqDyMPNRZvmp9q7TJfpHDR4fiALlVcR41RhzhiW93tZARc0aia7azHYDa0Qaw8+R1Wdj+2QmUSs3uAOzfX9AANADxqcYqjLqmssyj8YShjRLLjlBpAji/+XaofXqzsS7GN1RdeOGufnrQTikFsSFx0nS4f8KWK/kY91XGIxrRfXX5NN9fTzF3ieTC/p103uDuLFtY+8gD/vcDJ3TaP8sFo7+/ey4RDxiHqhOpa+NCs80ecR0XbQ/AeBXAvImu18S/9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rZ9rKprFQngGmhxXk2l57/sPYWya2/ZnBggR9c6xVP0=; b=tk4sI8rVVjBmy20P7fg/13+6x3CNUJg7bD/hozfKP7bYEdHsOlScbmAG5uAXnH6FefBOwLZXTqs74r3OzXjoJCMOm9PdAV10/VsiSLFjUvCgfqHwSaM48S6o9DmZtyrtH/YPZ6osfFOtEiKevP06lDngCiPmrTydg3XnKq+gLW7tHJW8D8n7Hq4kzfvQN9tFY8OgQCCR6hFKxzJreJoQxC8Ay96CTJDW0i2mhnH4ER2DTQcKlxy0QPAzx8RytpwJB7gjgUdA0fl8EWuGO42wXh8h7EN+b4xiNxA94iAydON8PxiTqiFWhDOyl1MnFXUTzykx43Z6cQQZf3Vj5RhELg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT3PR01MB296076.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:1a6::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.472.15; Wed, 30 Sep 2026 20:01:45 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%7]) with mapi id 15.21.0451.026; Wed, 30 Sep 2026 20:01:45 +0000 Message-ID: <07bc2a37-908e-4b32-8125-9e2b742ff639@efficios.com> Date: Wed, 30 Sep 2026 16:01:44 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/9] gdb: update comment of global_symbol_searcher::expand_symtabs To: "Rohr, Stephan" , "gdb-patches@sourceware.org" References: <20260929194119.155169-1-simon.marchi@efficios.com> <20260929194119.155169-7-simon.marchi@efficios.com> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0152.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:e::25) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT3PR01MB296076:EE_ X-MS-Office365-Filtering-Correlation-Id: eb169cf4-648b-473c-114d-08df1f2da78a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|366016|10070799003|1800799024|23010399003|10067099003|56012099006|4143699003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: vN9iVAKkhyVpVyPKlHL2toszBV+GJSxhhhvcy2M3FzVXvtPj0ZBvFe9bPxq23spRb1ROpGJlMm5VHXIA3su0kVLA86yLCoOA595ZrwbYtXA9ouHlf9PcEBABcik+bwzarDuGdz2VKrH7DSzx80m+6oqsUl7c01RV6HKw+/Li2lkcn5OIl5RrJ/oeJJtecHjz4RiFVtAPWclfQ4Q7SBSOq8++yylOZmBW1oh6i7VS1fKp7nxc/Rr430UCpqLkQ9A6/krdH9U/Yy+rFE28kv7XTd5Lx40jl8fKW7QwhHKxtPRw4QqXYiXVPl6yuazBNuPLMolKOm/ObsI3PveGd4WxkB3+IZVf+YvHy0BkCdhzTioCN2g/JKTTGfqLxW5CbJ0A9I1PzyY75ECJ+igcsBWR3aZjlOq7R2HNxyUpyE1gJueyEmXI8QOYZq57DdvjaN6uKZiYZwb9LMpS1hFOU+Q5oR+KklXJmO79roNMOdFRyS38SLMRlbeqIv0t8qXscO3mUwvPB6rbW8WnndGJ3+Vm08A4ZnlFckYj/uSs7uQDynJCISUMrPvXZyiagUqiZlvTt9ZmhaRivWgtDJy4AZrKnhFz3zjf+xNc9XOYTOETom0bUdmvxxRSdm7oTCZb6pbMCIoCM16ZKbZFvVOAjz3eaYu0QgWfE1JuJtoHRiP7mls= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(10070799003)(1800799024)(23010399003)(10067099003)(56012099006)(4143699003)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnYxSHVpcm0xeDJJQXU3dkVtT1k4TTdrOWVHQnBVSjhQM0VUNDVpZ3BGcUor?= =?utf-8?B?dGQreTZFdmFNbEsxL003RmtPZjRJM0RGS01JeVJ5eXcvRlVadWpoRVlvdWc4?= =?utf-8?B?TDJGUnduaDlVM2JRMWxsSSt6cDNOSnMxdTVKWVlCUXlrVDhmTHNOWS94K3A2?= =?utf-8?B?b2hOM05rZUZOQW8yaUJUVGxGTWJNeWNFbDZ2dXRpbU16SnZxejJxakRYb2xZ?= =?utf-8?B?OURzSUV2Z3REcWdWNlF0c2xRQllEcXU1d2ZDb3d3SmxscU5uUDN1ZS9BQUsz?= =?utf-8?B?ekZ4NzNSR3FZSWJGbXE1SElOTmk0VjgxRDg2R3pjNGxWTHZieUpGNzRTWFlj?= =?utf-8?B?Z1VVNkduMERSKzQvbDB0MTU5WG9va2NWSHlqeWdjU1YrdXkya0NIajdwNmNm?= =?utf-8?B?L3ZYU08ycUxnTGwvbHRxQmsvSUJ5Rmt1TXJ1aFVzWWR6ODkxbit2MnRVNUFi?= =?utf-8?B?eFNzZW1LSW9icm9YNDJMaGtQUlVYQ21RMzBJWUV2NDU5d013Z2J4cWtKKzBG?= =?utf-8?B?U2QxV3B2MkI4TEFRd2EralMxNGU2U3RFVUFkeG9Cc3VxSXdCelgwQ2ZJeVV4?= =?utf-8?B?clRyaDFKdjNBWkphYmZKaGg5bmZjYWwvT3htcVAyUnc3eVdqNGNCd1JoK1lH?= =?utf-8?B?N1BiejBpS3FSMWh4WHM4b0Vtd2Fsb1NUSW5hS1J0VnBXRU9DV0JrOUhYaWth?= =?utf-8?B?eGwwQnhDNGVXUGdUZ0F5VFVncGkwS0NiaXZYZjJIbzljNWRxUFhuOGloRVZY?= =?utf-8?B?cWlJODhKdzlZU3FwWCt4ai82cTBwSDhVRk9mNHlZdTc3K3ZpM1ZsbEl6TXZu?= =?utf-8?B?eTByOXNEWVptdFhydUFNZWs1c3hGYmtWNytuQzAxUDR6Mm9pUzdXVUN5WUlX?= =?utf-8?B?Uzd2d0Fkay9QQklWMjIwSW9NQ0gvTStYSjJtVXVFYmdzTlEvQXIwWC9rZHhE?= =?utf-8?B?L0JqM2JqMExYSC9JZThoWU5UWk10SFJzK21nSlk2eGZYajN6MVRSdHcrRjJQ?= =?utf-8?B?OGpoU0lDK0NRU0RYU0VJWDJ3WkZBYWY2TWE4ZlR1TDNzOG1FSHllM3oydEYz?= =?utf-8?B?cWdNU1BsZE5GVHhTUWtZeEVkcEVLanRwV0ZyY1BUNksyMVZSNUdrb2toQXZl?= =?utf-8?B?eW5GSDdQUStScERDaVNVNzNzWlljTDdtVU9hRlgxTm9RTytYQmhydzNpZVlG?= =?utf-8?B?azR6U3htd2YxQ1ZoQmthT0Vtb0krTlFuZCtrcWdCUFBUcW1PaVIrUDdTUmFZ?= =?utf-8?B?TW5EKzhibTZuN2hCU2NlUUhlQXlsREJhM3E3RVlPN1djcSsrSEZad0RMQk8y?= =?utf-8?B?UkNKZFViYnhIbWk1emNXZ2JDN1d6ZFVRSjZBdDZVV3p1OFpmQjR4Q3V4ZnBi?= =?utf-8?B?YkxuWTA0MEY1QXROMklkTjVLUitvNzE1MWVrU0NLOUt6c2ZCamM1WDZoZDBV?= =?utf-8?B?VXlNUUk5Z2hHWmdrdEwxcFgzZHY2aitlVEQ1U0haTFpGbWVwRjVTRUJrVCtL?= =?utf-8?B?ekNZTEM4aU92Zkdxd1pmNVNKaWxsc21reklUWGJmMUpuK3NVVHY5V0tXVHZL?= =?utf-8?B?dk9oS0syTFQwUUsxcy9SemFSSnYvSUhRT2Fud3NKaDFObWg1SkRlT1JGMGtW?= =?utf-8?B?Z29NcU5pcDZpZ2xFUDM5S3UrT2pQdGwzK25xcng4OWV0Ym4vdkdJZmxoZ0ZJ?= =?utf-8?B?d2pCU2ZueUpXam5pVWl1QmZwVk9WR3J6RnkyWGtGQXVxc1lmVXNOTmVsdjJj?= =?utf-8?B?d0owYS9HMkZjaU5ycTlyWjB0VTA0dVZwQmZGQnA0L0tDYjVZb3lESkl0WHRC?= =?utf-8?B?MnRJYzlyTXdQNVdSbytYM2dRSGdaY0ZaWDNPbDdPMzl3OVRDcnkwWTBVQXhH?= =?utf-8?B?Y1c5TGpDQ1E1U21TNEJIYkU5RCtDZDNwYVJ1TWYzOUpZbVVNVEpjZllnNTF5?= =?utf-8?B?L3N5SGlZUE5UVXJBc1MySEZRZ3ZhaSt4OVpMWElLZHZreE45a21aay9pRDI1?= =?utf-8?B?RTZ1MWNyN1p6alBTYzlRdGVjeHo0eHptMmprRVVKWDcxb0lYR1Jzd0hUek9y?= =?utf-8?B?T1dSczRYbVRNQzUzUGVMYXZwVzQ1b0N1UDBJcFJyM2NEc2Y2d3huclQvVlkr?= =?utf-8?B?cTZOM3JGRmFiUUJBNTgzd2hDNTVlRU9ocmRWUDVRYU9EK1h0dGVMQjVoSU0w?= =?utf-8?B?dEZBYXpKa0dadWNYcUZLbUlXcUZzSkRLUXhDR1dDaTJDNEgyK1JLSzVXb3Yz?= =?utf-8?B?MTVJMnBTRlFybC9WL2VneHRTVzA2bXlzSnF1VElqaVJNK3R4Z0hUOEVHKzNt?= =?utf-8?B?VDU4Z0toZ2RtSklUOFo5TWplamNSM1NWL1lIQWNzRDBXS3Vwa2tYLzc1MW9u?= =?utf-8?Q?xsL7B1bpMEbpGvMJ910ksrx4fy+YUa9UHAS1PRKC8PfNt?= X-MS-Exchange-AntiSpam-MessageData-1: 2kQ4vticpCKkyg== X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb169cf4-648b-473c-114d-08df1f2da78a X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2026 20:01:45.5730 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /jiFiFqy+ohiTFTlBM4aHGl8hwcFUiTjgDx4XIshNJUYue5moF5T64eogK2b3dzvT3Cj8bTbZC3XTSICNe+TdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB296076 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-09-30 09:08, Rohr, Stephan wrote: >> diff --git a/gdb/symtab.h b/gdb/symtab.h >> index 50d7000681df..acbe41d131b7 100644 >> --- a/gdb/symtab.h >> +++ b/gdb/symtab.h >> @@ -2676,8 +2676,9 @@ class global_symbol_searcher >> std::optional compile_type_regex () const; >> >> /* Expand symtabs in OBJFILE that match NAME_REGEX, are of type >> M_KIND. >> - Return true if any msymbols were seen that we should later consider >> - adding to the results list. */ >> + Return true if a matching function msymbol without debug info was >> + seen, meaning that msymbols should later be considered for the results >> + list. */ > > If we update comment, what about updating the first sentence to > > "Expand symtabs in OBJFILE that match NAME_REGEX and are of type M_KIND." > > This reads better from my point of view. Agreed, fixed. > I was also wondering if it's worth updating the comments inside the "expand_symtabs" > function: > > - [..] When no file names were given the caller unconditionally rescans [..] > > The "unconditionally" can be dropped. It is gated in "search ()". I'll do that. Honestly, I'm not even sure what this part of the comment brings. > - The comment this contains "SEARCH_VAR_DOMAIN". Should this be changed to > "symbol_search_kind:: VARIABLE" instead? Not sure if this is the right patch for this > change. I'll just say "for variables". Simon