From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6X2dGhyCvmo2VCQAWB0awg (envelope-from ) for ; Thu, 01 Oct 2026 11:54:04 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZorjQPCz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 690321E051; Thu, 01 Oct 2026 11:54:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D66A41E01F for ; Thu, 01 Oct 2026 11:54:03 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7F1484BB1C09 for ; Thu, 1 Oct 2026 15:54:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7F1484BB1C09 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZorjQPCz Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id DCCF94BA2E36 for ; Thu, 1 Oct 2026 15:53:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DCCF94BA2E36 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DCCF94BA2E36 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790870020; cv=none; b=N6AQ5omw5azzVLb/WrK2upFk7n2jLRFAiAKOLSwtuzXu6b8TBTGqwmGXGgeM3YagJShA8CtIURV3sIebZ4mIUpkVgvT+KSTv6G7KvHuQxy4vgZ1wh6c/YD9fBkAwzgk+Jn1THcwKeU0rpcN7+btsCnkJYANQSjxozv5Qe1K2LxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790870020; c=relaxed/simple; bh=VAmnLR+Jrz0SnxgSIukkEu5SnWSehA/0fWU+KjKptkw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kxCUudNGYNlRVXIvnXLgk7+BO3+SqSIip/dhWt0aqFmSBg7wdTtUnZ+AnyUzMTEdQN/dxnll8ynNUulBN0SJ9dZCUh6cd6URNrMUWDSM2ecBYi2fSsfSHM5Ve+G8U+tkMRPvk5WFNaM1BjgB8ELD9cgTkxI7uXyjUVCnV+XVeYI= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ZorjQPCz DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DCCF94BA2E36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790870019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6DUzBNpnVgF5qUkVWEEHjsnlD1uC2dB3dcCHew2NMBs=; b=ZorjQPCzmfT0DYUniXzdk1/OhwZF9c2M4wms0EVyE1dFLtZc4XUwgm4cZ/4l4aiv6bgSMz ieiblD4uPBEe+0ivvRAOob/4FkCqmqzxl9p7kjjb1Qzlra73DEGVj1Zk+dtamFusYhDLCe J67DKeUFJo8Hgj6oEARsXFIJdI9xEEE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-75uDruBEPaCIVGhJiXjjdw-1; Thu, 01 Oct 2026 11:53:38 -0400 X-MC-Unique: 75uDruBEPaCIVGhJiXjjdw-1 X-Mimecast-MFC-AGG-ID: 75uDruBEPaCIVGhJiXjjdw_1790870017 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4a013ea30c0so18811565e9.0 for ; Thu, 01 Oct 2026 08:53:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790870017; x=1791474817; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=6DUzBNpnVgF5qUkVWEEHjsnlD1uC2dB3dcCHew2NMBs=; b=lEaQ3QJkW9ahDXLMI+Pz3R3VkFQf1l+VzYrTVJI7gsJlek3fxkyVcb/SGMF0EFLo2f cM7U6mJjXkrx+VDEZ910R+5MbpNEvkt0qAajGEPgpLDAtZZd/aqBrUIUNHgSMBjBeBoP zPX/5o2vvrCaoCJvKEFlGGx1vLTUof/Kr1PFjYYCl5dsyVK+uD6GJfIiSZ698Tznt/7H cGEo7dTc7aF4ukVNuwD7ZB5KBun4z5mW9O/QOpIf3wj1Kb3xvYTKkYNjfBlSGcZURf30 LPVZPUaMcFxnvS5dwAJAsDVsqdxaqROmMHAnhtk5oaZkK46w76ub3uD5SG0ZjSt/GIKX 1POQ== X-Forwarded-Encrypted: i=1; AKwUvBxlDLuWO+Z54wjAmmtGPjxyFgK/CEKrf8tF27FkOAoVj5Dp3qlSZZaEpA/9vwhNP6RPX5P7hiI2+uQytw==@sourceware.org X-Gm-Message-State: AFuF++mHcIx6bnmhCFKUnb+nB64Z3tBSDgeiIKX0S4mvZ0wMbWKZgBXa nCpCnpuJFJfSECiVDAEMUilgj2REoCol1ubHD3wxIDI+b1/LitaJOUoaB40U9zkj3ZHhyN90E4J uycS+bqL+aao19NyVZoXgQdD8M7wETw49W7zEeJXcYYCcXUGRTh5HxHIAd+6STFg= X-Gm-Gg: AYBFou0nOReK620I1e2iYxgIKFZ9NY+Eunz/bH5qyMBy52WRZnQShPcc6wbdgS1EQxj qxkV0xhaA/PQ+ZC4DCU9oDEJcajuPCgtQVS4Ee629MCMxm45APdGUy/fkm5NkDiTKVAyQzOxOVM iAf2hH9vnzQBkkWYCcHd6mNR5bI/pGK1090X2sQKIX+Dz2Pz2OxBRQAxn8u3GWXGL0Y5JkeL7Gn evTk1GO9OM1lk/WmdfTsMB3WINJYxruws36kJhGi0i9NR9ahGbTOoWHOQeseubi6dWWlRvNmt41 f7/FF2Y6CwmI4RZhVmWF2VT/ra6V5VSc38Dkf+g+6AqmRXxP2e9HAjk68xrAK0jSrVDQ X-Received: by 2002:a05:600c:5489:b0:49c:fea3:8633 with SMTP id 5b1f17b1804b1-4a02769f2f6mr657595e9.24.1790870017244; Thu, 01 Oct 2026 08:53:37 -0700 (PDT) X-Received: by 2002:a05:600c:5489:b0:49c:fea3:8633 with SMTP id 5b1f17b1804b1-4a02769f2f6mr657125e9.24.1790870016726; Thu, 01 Oct 2026 08:53:36 -0700 (PDT) Received: from localhost ([213.31.44.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a01f98f72fsm72267265e9.11.2026.10.01.08.53.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2026 08:53:35 -0700 (PDT) From: Andrew Burgess To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH v2 10/11] gdb: change some pointers to references in global_symbol_searcher In-Reply-To: <20261001020952.698419-11-simon.marchi@polymtl.ca> References: <20260929194119.155169-1-simon.marchi@efficios.com> <20261001020952.698419-11-simon.marchi@polymtl.ca> Date: Thu, 01 Oct 2026 16:53:34 +0100 Message-ID: <87mrsxxvr5.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: BqnuqZlPp-D3zGCGceN9aV4SG_2A_GalMXaAXtWSSkA_1790870017 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org simon.marchi@polymtl.ca writes: > From: Simon Marchi > > add_matching_symbols and add_matching_msymbols take the container to > add results to as a pointer, but it can never be nullptr. Pass it by > reference instead. > > The objfiles are also passed by pointer to the various helper methods, > switch that to references. > > Change-Id: I65d8e14f2f3152d83afbe3b348fc91a8817b87fa > --- > gdb/symtab.c | 39 +++++++++++++++++++-------------------- > gdb/symtab.h | 10 +++++----- > 2 files changed, 24 insertions(+), 25 deletions(-) > > diff --git a/gdb/symtab.c b/gdb/symtab.c > index ef21f285abcd..af748190ddd5 100644 > --- a/gdb/symtab.c > +++ b/gdb/symtab.c > @@ -4945,16 +4945,16 @@ global_symbol_searcher::add_matching_msymbols > symbol might be found via find_pc_symtab. */ > if (m_kind == symbol_search_kind::FUNCTION > && (find_compunit_symtab_for_pc > - (msymbol->value_address (objfile)) != NULL)) > + (msymbol->value_address (&objfile)) != NULL)) > continue; > > if (lookup_symbol_in_objfile_from_linkage_name > - (objfile, msymbol->linkage_name (), SEARCH_VFT).symbol != NULL) > + (&objfile, msymbol->linkage_name (), SEARCH_VFT).symbol != NULL) > continue; Two lines above here can replace NULL with nullptr. With that done: Approved-By: Andrew Burgess Thanks, Andrew