From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix PR16508
Date: Wed, 05 Mar 2014 20:03:00 -0000 [thread overview]
Message-ID: <87lhwo76qv.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1392447370-22318-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Sat, 15 Feb 2014 14:56:10 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> 2014-02-15 Yao Qi <yao@codesourcery.com>
Yao> PR breakpoints/16508
Yao> * tracepoint.c (check_trace_running): New function.
Yao> (trace_find_command): Move code to check_trace_running and
Yao> call check_trace_running.
Yao> (trace_find_pc_command): Likewise.
Yao> (trace_find_tracepoint_command): Likewise.
Yao> (trace_find_line_command): Likewise.
Yao> (trace_find_range_command): Likewise.
Yao> * tracepoint.h (check_trace_running): Likewise.
Yao> * mi/mi-main.c (mi_cmd_trace_find): Call check_trace_running.
One trivial nit here.
Yao> +if [prepare_for_testing $expfile $executable $srcfile \
Yao> + [list debug]] {
Yao> + untested "failed to prepare for trace tests"
prepare calls untested for you, so no need to do it again.
Ok with this change.
Tom
next prev parent reply other threads:[~2014-03-05 20:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 6:58 Yao Qi
2014-03-05 2:08 ` ping: " Yao Qi
2014-03-05 20:03 ` Tom Tromey [this message]
2014-03-05 20:33 ` Pedro Alves
2014-03-06 3:39 ` Yao Qi
2014-03-06 13:35 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhwo76qv.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox