From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28644 invoked by alias); 5 Mar 2014 20:03:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28591 invoked by uid 89); 5 Mar 2014 20:03:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Mar 2014 20:03:41 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s25K3cfP006465 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 5 Mar 2014 15:03:38 -0500 Received: from barimba (ovpn-113-183.phx2.redhat.com [10.3.113.183]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s25K3at9020255 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 5 Mar 2014 15:03:37 -0500 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH] Fix PR16508 References: <1392447370-22318-1-git-send-email-yao@codesourcery.com> Date: Wed, 05 Mar 2014 20:03:00 -0000 In-Reply-To: <1392447370-22318-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Sat, 15 Feb 2014 14:56:10 +0800") Message-ID: <87lhwo76qv.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-03/txt/msg00137.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> 2014-02-15 Yao Qi Yao> PR breakpoints/16508 Yao> * tracepoint.c (check_trace_running): New function. Yao> (trace_find_command): Move code to check_trace_running and Yao> call check_trace_running. Yao> (trace_find_pc_command): Likewise. Yao> (trace_find_tracepoint_command): Likewise. Yao> (trace_find_line_command): Likewise. Yao> (trace_find_range_command): Likewise. Yao> * tracepoint.h (check_trace_running): Likewise. Yao> * mi/mi-main.c (mi_cmd_trace_find): Call check_trace_running. One trivial nit here. Yao> +if [prepare_for_testing $expfile $executable $srcfile \ Yao> + [list debug]] { Yao> + untested "failed to prepare for trace tests" prepare calls untested for you, so no need to do it again. Ok with this change. Tom