Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: ping: [PATCH] Fix PR16508
Date: Wed, 05 Mar 2014 02:08:00 -0000	[thread overview]
Message-ID: <5316869C.3060202@codesourcery.com> (raw)
In-Reply-To: <1392447370-22318-1-git-send-email-yao@codesourcery.com>

On 02/15/2014 02:56 PM, Yao Qi wrote:
> This patch fixes PR16508, which is about MI "-trace-find frame-number 0"
> behaves differently from CLI "tfind 0".  In CLI, we check both
> status->running and status->filename, but in MI, we only check
> status->running, which looks wrong to me.  This patch moves the code
> of checking to a new function check_trace_running, and use it in
> both CLI and MI.
> 
> This patch also adds a test case pr16508.exp, which fails without this
> fix, and passes with the fix applied.
> 
>   FAIL: gdb.trace/pr16508.exp: interpreter-exec mi "-trace-find frame-number 0"
> 
> Patch is regression tested on x86_64-linux.
> 
> gdb:
> 
> 2014-02-15  Yao Qi  <yao@codesourcery.com>
> 
> 	PR breakpoints/16508
> 	* tracepoint.c (check_trace_running): New function.
> 	(trace_find_command): Move code to check_trace_running and
> 	call check_trace_running.
> 	(trace_find_pc_command): Likewise.
> 	(trace_find_tracepoint_command): Likewise.
> 	(trace_find_line_command): Likewise.
> 	(trace_find_range_command): Likewise.
> 	* tracepoint.h (check_trace_running): Likewise.
> 	* mi/mi-main.c (mi_cmd_trace_find): Call check_trace_running.
> 
> gdb/testsuite:
> 
> 2014-02-15  Yao Qi  <yao@codesourcery.com>
> 
> 	* gdb.trace/pr16508.exp: New file.

Ping.  https://sourceware.org/ml/gdb-patches/2014-02/msg00508.html

-- 
Yao (齐尧)


  reply	other threads:[~2014-03-05  2:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-15  6:58 Yao Qi
2014-03-05  2:08 ` Yao Qi [this message]
2014-03-05 20:03 ` Tom Tromey
2014-03-05 20:33   ` Pedro Alves
2014-03-06  3:39     ` Yao Qi
2014-03-06 13:35     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5316869C.3060202@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox