From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30173 invoked by alias); 5 Mar 2014 02:08:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30145 invoked by uid 89); 5 Mar 2014 02:08:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Mar 2014 02:08:44 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1WL1GC-0005B4-Cv from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Tue, 04 Mar 2014 18:08:40 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 4 Mar 2014 18:08:40 -0800 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Tue, 4 Mar 2014 18:08:39 -0800 Message-ID: <5316869C.3060202@codesourcery.com> Date: Wed, 05 Mar 2014 02:08:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Subject: ping: [PATCH] Fix PR16508 References: <1392447370-22318-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1392447370-22318-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00101.txt.bz2 On 02/15/2014 02:56 PM, Yao Qi wrote: > This patch fixes PR16508, which is about MI "-trace-find frame-number 0" > behaves differently from CLI "tfind 0". In CLI, we check both > status->running and status->filename, but in MI, we only check > status->running, which looks wrong to me. This patch moves the code > of checking to a new function check_trace_running, and use it in > both CLI and MI. > > This patch also adds a test case pr16508.exp, which fails without this > fix, and passes with the fix applied. > > FAIL: gdb.trace/pr16508.exp: interpreter-exec mi "-trace-find frame-number 0" > > Patch is regression tested on x86_64-linux. > > gdb: > > 2014-02-15 Yao Qi > > PR breakpoints/16508 > * tracepoint.c (check_trace_running): New function. > (trace_find_command): Move code to check_trace_running and > call check_trace_running. > (trace_find_pc_command): Likewise. > (trace_find_tracepoint_command): Likewise. > (trace_find_line_command): Likewise. > (trace_find_range_command): Likewise. > * tracepoint.h (check_trace_running): Likewise. > * mi/mi-main.c (mi_cmd_trace_find): Call check_trace_running. > > gdb/testsuite: > > 2014-02-15 Yao Qi > > * gdb.trace/pr16508.exp: New file. Ping. https://sourceware.org/ml/gdb-patches/2014-02/msg00508.html -- Yao (齐尧)