From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>, Yao Qi <yao@codesourcery.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix PR16508
Date: Thu, 06 Mar 2014 13:35:00 -0000 [thread overview]
Message-ID: <20140306133544.GG16858@adacore.com> (raw)
In-Reply-To: <53178A28.8060206@redhat.com>
> if [prepare_for_testing "failed to prepare for trace tests" \
> $executable $srcfile [list debug]] {
>
> Although we do that all over the place, passing $expfile
> to untested is useless, as that information will be
> in the gdb.sum before UNTESTED anyway.
>
> I'd support us starting to use this pattern more.
I think that's a good idea. I've updated the Wiki's "testcase cookbook"
accordingly. My only concern with the current verbiage is copy/pasting
of existing examples will always require some additional edits to
adjust the message for the testcase. In the wiki example, I used
"[***FILL ME IN***]" which (I think) will cause a TCL error, but
the favorite programming method being copy-and-modify, I think we are
going to miss some. So perhaps something a little more generic?
--
Joel
prev parent reply other threads:[~2014-03-06 13:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 6:58 Yao Qi
2014-03-05 2:08 ` ping: " Yao Qi
2014-03-05 20:03 ` Tom Tromey
2014-03-05 20:33 ` Pedro Alves
2014-03-06 3:39 ` Yao Qi
2014-03-06 13:35 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306133544.GG16858@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox