From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13136 invoked by alias); 6 Mar 2014 13:35:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13127 invoked by uid 89); 6 Mar 2014 13:35:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 06 Mar 2014 13:35:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 97505116689; Thu, 6 Mar 2014 08:35:41 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 35GxF6TJonMB; Thu, 6 Mar 2014 08:35:41 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5C7E9116647; Thu, 6 Mar 2014 08:35:41 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 54EDDE0CE3; Thu, 6 Mar 2014 05:35:44 -0800 (PST) Date: Thu, 06 Mar 2014 13:35:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: Tom Tromey , Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix PR16508 Message-ID: <20140306133544.GG16858@adacore.com> References: <1392447370-22318-1-git-send-email-yao@codesourcery.com> <87lhwo76qv.fsf@fleche.redhat.com> <53178A28.8060206@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53178A28.8060206@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-03/txt/msg00156.txt.bz2 > if [prepare_for_testing "failed to prepare for trace tests" \ > $executable $srcfile [list debug]] { > > Although we do that all over the place, passing $expfile > to untested is useless, as that information will be > in the gdb.sum before UNTESTED anyway. > > I'd support us starting to use this pattern more. I think that's a good idea. I've updated the Wiki's "testcase cookbook" accordingly. My only concern with the current verbiage is copy/pasting of existing examples will always require some additional edits to adjust the message for the testcase. In the wiki example, I used "[***FILL ME IN***]" which (I think) will cause a TCL error, but the favorite programming method being copy-and-modify, I think we are going to miss some. So perhaps something a little more generic? -- Joel