From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tom@tromey.com>, GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Make '{putchar,fputc}_unfiltered' use 'fputs_unfiltered'
Date: Fri, 21 Feb 2020 05:53:00 -0000 [thread overview]
Message-ID: <87lfowwknr.fsf@redhat.com> (raw)
In-Reply-To: <20200221035717.GA21588@adacore.com> (Joel Brobecker's message of "Fri, 21 Feb 2020 07:57:17 +0400")
On Thursday, February 20 2020, Joel Brobecker wrote:
> Hi Sergio and Tom,
Hey Joel,
> On Thu, Feb 20, 2020 at 04:04:05PM -0500, Sergio Durigan Junior wrote:
>> On Thursday, February 20 2020, Tom Tromey wrote:
>>
>> >>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>> >
>> > Sergio> gdb/ChangeLog:
>> > Sergio> 2020-02-20 Sergio Durigan Junior <sergiodj@redhat.com>
>> > Sergio> Tom Tromey <tom@tromey.com>
>> > Sergio> * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
>> > Sergio> of 'fputc_unfiltered'.
>> > Sergio> (putchar_unfiltered): Call 'fputc_unfiltered'.
>> > Sergio> (fputc_unfiltered): Call 'fputs_unfiltered'.
>> >
>> > Looks good to me. Thanks for doing this.
>>
>> Thanks, pushed.
>>
>> 3f702acd7d562d3a33c59d6398ae74058438d2c7
>
> I think the commit that Sergio incriminated is also in gdb-9-branch.
> Do you confirm?
Yes, the bug also happens in gdb-9-branch.
> If yes, what about creating a GDB PR, and backporting this change
> to the gdb-9-branch (all changes after the .1 must have a PR)?
I can do that. Just not right now; I need to be in my bed sleeping 30
minutes ago ;-).
> The change looks relatively safe to me, but maybe it's not as simple
> as we might think, especially since this section of the code _is_ quite
> central...
Yeah, this code is quite messy, and even though the change is somewhat
"self-contained". What if we wait a few days/weeks before I open the PR
and do the backport? Due to this code being quite central as you said,
I think it should not take long for complaints to start coming our way,
assuming there is a bug to be found.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2020-02-21 5:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 4:12 Sergio Durigan Junior
2020-02-20 19:59 ` Tom Tromey
2020-02-20 21:04 ` Sergio Durigan Junior
2020-02-21 3:57 ` Joel Brobecker
2020-02-21 5:53 ` Sergio Durigan Junior [this message]
2020-02-21 10:13 ` Joel Brobecker
2020-02-21 18:31 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfowwknr.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox