From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13771 invoked by alias); 21 Feb 2020 05:53:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13761 invoked by uid 89); 21 Feb 2020 05:53:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1834 X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Feb 2020 05:53:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582264432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=isBlpsQg8TQ4iJKOzmUAIaa1Z4h9qP+6rEboG3okjKs=; b=GDGqFk+lNJFbhSOYtGVvhI2CB645ft8plGsr9/vSdnOk438SyY3AxNmLQxa5DOG30aIoLn uq9EAVmjc0Zo2L8bznELcL5fTOSgjfuDjq+k8i2jJHfpmvfr48r7z4TfO1I/ZPNBf9owrT y1xE/X6upyI3QEXAerk9MNkWLUfdYFU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-264-ADjK_K9DMfyd36T0wI3OJg-1; Fri, 21 Feb 2020 00:53:46 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7E07F8017CC; Fri, 21 Feb 2020 05:53:45 +0000 (UTC) Received: from localhost (unused-10-15-17-54.yyz.redhat.com [10.15.17.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46245194B2; Fri, 21 Feb 2020 05:53:45 +0000 (UTC) From: Sergio Durigan Junior To: Joel Brobecker Cc: Tom Tromey , GDB Patches Subject: Re: [PATCH] Make '{putchar,fputc}_unfiltered' use 'fputs_unfiltered' References: <20200220041214.155369-1-sergiodj@redhat.com> <87v9o1ghdm.fsf@tromey.com> <87ftf5x96i.fsf@redhat.com> <20200221035717.GA21588@adacore.com> Date: Fri, 21 Feb 2020 05:53:00 -0000 In-Reply-To: <20200221035717.GA21588@adacore.com> (Joel Brobecker's message of "Fri, 21 Feb 2020 07:57:17 +0400") Message-ID: <87lfowwknr.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00845.txt.bz2 On Thursday, February 20 2020, Joel Brobecker wrote: > Hi Sergio and Tom, Hey Joel, > On Thu, Feb 20, 2020 at 04:04:05PM -0500, Sergio Durigan Junior wrote: >> On Thursday, February 20 2020, Tom Tromey wrote: >>=20 >> >>>>>> "Sergio" =3D=3D Sergio Durigan Junior write= s: >> > >> > Sergio> gdb/ChangeLog: >> > Sergio> 2020-02-20 Sergio Durigan Junior >> > Sergio> Tom Tromey >> > Sergio> * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead >> > Sergio> of 'fputc_unfiltered'. >> > Sergio> (putchar_unfiltered): Call 'fputc_unfiltered'. >> > Sergio> (fputc_unfiltered): Call 'fputs_unfiltered'. >> > >> > Looks good to me. Thanks for doing this. >>=20 >> Thanks, pushed. >>=20 >> 3f702acd7d562d3a33c59d6398ae74058438d2c7 > > I think the commit that Sergio incriminated is also in gdb-9-branch. > Do you confirm? Yes, the bug also happens in gdb-9-branch. > If yes, what about creating a GDB PR, and backporting this change > to the gdb-9-branch (all changes after the .1 must have a PR)? I can do that. Just not right now; I need to be in my bed sleeping 30 minutes ago ;-). > The change looks relatively safe to me, but maybe it's not as simple > as we might think, especially since this section of the code _is_ quite > central... Yeah, this code is quite messy, and even though the change is somewhat "self-contained". What if we wait a few days/weeks before I open the PR and do the backport? Due to this code being quite central as you said, I think it should not take long for complaints to start coming our way, assuming there is a bug to be found. Thanks, --=20 Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/