Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Tom Tromey <tom@tromey.com>, GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Make '{putchar,fputc}_unfiltered' use 'fputs_unfiltered'
Date: Fri, 21 Feb 2020 10:13:00 -0000	[thread overview]
Message-ID: <20200221101323.GA8294@adacore.com> (raw)
In-Reply-To: <87lfowwknr.fsf@redhat.com>

> > I think the commit that Sergio incriminated is also in gdb-9-branch.
> > Do you confirm?
> 
> Yes, the bug also happens in gdb-9-branch.
> 
> > If yes, what about creating a GDB PR, and backporting this change
> > to the gdb-9-branch (all changes after the .1 must have a PR)?
> 
> I can do that.  Just not right now; I need to be in my bed sleeping 30
> minutes ago ;-).

;-)

> > The change looks relatively safe to me, but maybe it's not as simple
> > as we might think, especially since this section of the code _is_ quite
> > central...
> 
> Yeah, this code is quite messy, and even though the change is somewhat
> "self-contained".  What if we wait a few days/weeks before I open the PR
> and do the backport?  Due to this code being quite central as you said,
> I think it should not take long for complaints to start coming our way,
> assuming there is a bug to be found.

That definitely works. Unless we discover this is a crippling issue
that deserves an emergency release, we have a solid couple of months
to decide, really. More if we need...

Thanks Sergio!

-- 
Joel


  reply	other threads:[~2020-02-21 10:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20  4:12 Sergio Durigan Junior
2020-02-20 19:59 ` Tom Tromey
2020-02-20 21:04   ` Sergio Durigan Junior
2020-02-21  3:57     ` Joel Brobecker
2020-02-21  5:53       ` Sergio Durigan Junior
2020-02-21 10:13         ` Joel Brobecker [this message]
2020-02-21 18:31           ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200221101323.GA8294@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@redhat.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox