From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27818 invoked by alias); 21 Feb 2020 10:13:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27760 invoked by uid 89); 21 Feb 2020 10:13:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=deserves, HX-Languages-Length:1148, our X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Feb 2020 10:13:30 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D28C91169F1; Fri, 21 Feb 2020 05:13:28 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8AR8VajKWFbR; Fri, 21 Feb 2020 05:13:28 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6DDF31169CD; Fri, 21 Feb 2020 05:13:28 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D713683853; Fri, 21 Feb 2020 14:13:23 +0400 (+04) Date: Fri, 21 Feb 2020 10:13:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: Tom Tromey , GDB Patches Subject: Re: [PATCH] Make '{putchar,fputc}_unfiltered' use 'fputs_unfiltered' Message-ID: <20200221101323.GA8294@adacore.com> References: <20200220041214.155369-1-sergiodj@redhat.com> <87v9o1ghdm.fsf@tromey.com> <87ftf5x96i.fsf@redhat.com> <20200221035717.GA21588@adacore.com> <87lfowwknr.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lfowwknr.fsf@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2020-02/txt/msg00850.txt.bz2 > > I think the commit that Sergio incriminated is also in gdb-9-branch. > > Do you confirm? > > Yes, the bug also happens in gdb-9-branch. > > > If yes, what about creating a GDB PR, and backporting this change > > to the gdb-9-branch (all changes after the .1 must have a PR)? > > I can do that. Just not right now; I need to be in my bed sleeping 30 > minutes ago ;-). ;-) > > The change looks relatively safe to me, but maybe it's not as simple > > as we might think, especially since this section of the code _is_ quite > > central... > > Yeah, this code is quite messy, and even though the change is somewhat > "self-contained". What if we wait a few days/weeks before I open the PR > and do the backport? Due to this code being quite central as you said, > I think it should not take long for complaints to start coming our way, > assuming there is a bug to be found. That definitely works. Unless we discover this is a crippling issue that deserves an emergency release, we have a solid couple of months to decide, really. More if we need... Thanks Sergio! -- Joel