From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tom@tromey.com>, GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Make '{putchar,fputc}_unfiltered' use 'fputs_unfiltered'
Date: Fri, 21 Feb 2020 18:31:00 -0000 [thread overview]
Message-ID: <87blprvll2.fsf@redhat.com> (raw)
In-Reply-To: <20200221101323.GA8294@adacore.com> (Joel Brobecker's message of "Fri, 21 Feb 2020 14:13:23 +0400")
On Friday, February 21 2020, Joel Brobecker wrote:
>> > The change looks relatively safe to me, but maybe it's not as simple
>> > as we might think, especially since this section of the code _is_ quite
>> > central...
>>
>> Yeah, this code is quite messy, and even though the change is somewhat
>> "self-contained". What if we wait a few days/weeks before I open the PR
>> and do the backport? Due to this code being quite central as you said,
>> I think it should not take long for complaints to start coming our way,
>> assuming there is a bug to be found.
>
> That definitely works. Unless we discover this is a crippling issue
> that deserves an emergency release, we have a solid couple of months
> to decide, really. More if we need...
Good deal :-).
> Thanks Sergio!
Thank *you* for bringing this to my attention!
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
prev parent reply other threads:[~2020-02-21 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 4:12 Sergio Durigan Junior
2020-02-20 19:59 ` Tom Tromey
2020-02-20 21:04 ` Sergio Durigan Junior
2020-02-21 3:57 ` Joel Brobecker
2020-02-21 5:53 ` Sergio Durigan Junior
2020-02-21 10:13 ` Joel Brobecker
2020-02-21 18:31 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blprvll2.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox