From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/5] Return error code in get_number
Date: Thu, 15 May 2014 17:58:00 -0000 [thread overview]
Message-ID: <87k39mapqj.fsf@fleche.redhat.com> (raw)
In-Reply-To: <53264680.9090704@codesourcery.com> (Yao Qi's message of "Mon, 17 Mar 2014 08:49:04 +0800")
Tom> It seems to me that an MI client already knows all the breakpoint
Tom> numbers. I'm having trouble picturing the scenario where I'd want my MI
Tom> client to use a convenience variable instead.
Yao> This facilitates writing MI test cases that we don't have to hard-code
Yao> breakpoint numbers anymore. Keith pointed this out in the review
Yao> https://sourceware.org/ml/gdb-patches/2014-01/msg00824.html and I think
Yao> that is good to have, so I write this patch series. Can this justify
Yao> the changes in this series?
I am not opposed to it but I would like to gently push back a little.
It seems to me that if the proposed patches are there to help with a
deficiency in the test suite, then it would be better to fix the test
suite. Say, by implementing a way to extract the breakpoint number and
make it available to the Tcl code. Did you consider this approach? And
if so what made you reject it?
Tom
prev parent reply other threads:[~2014-05-15 17:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 2:35 Yao Qi
2014-03-13 2:35 ` [PATCH 1/5] Remove argument 'state' from get_tracepoint_by_number Yao Qi
2014-03-13 2:35 ` [PATCH 3/5] Emit wrong value error when parsing range Yao Qi
2014-03-13 2:35 ` [PATCH 2/5] Change argument 'args' of get_tracepoint_by_number to char * Yao Qi
2014-03-13 2:35 ` [PATCH 5/5] Accept convenience variable in commands -break-passcount and -break-commands Yao Qi
2014-03-14 8:22 ` Eli Zaretskii
2014-03-13 2:35 ` [PATCH 4/5] get_number returns status in details Yao Qi
2014-03-13 15:14 ` [PATCH 0/5] Return error code in get_number Tom Tromey
2014-03-14 0:59 ` Yao Qi
2014-03-14 14:38 ` Tom Tromey
2014-03-17 0:51 ` Yao Qi
2014-05-15 17:58 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k39mapqj.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox