Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 3/5] Emit wrong value error when parsing range
Date: Thu, 13 Mar 2014 02:35:00 -0000	[thread overview]
Message-ID: <1394677950-4054-4-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1394677950-4054-1-git-send-email-yao@codesourcery.com>

The current code in get_number_or_range doesn't check the return value
of get_number, so current gdb does:

 (gdb) thread apply 1-1.2 bt
 inverted range

which is a little bit confusing.  This patch adds a check to
get_number's return value, and emit error "wrong value" if return
value is zero.  With this patch applied, gdb prints:

 (gdb) thread apply 1-1.2 bt
 wrong value

gdb:

2014-03-13  Yao Qi  <yao@codesourcery.com>

	* cli/cli-utils.c (get_number_or_range): Error out if get_number
	returns zero.
---
 gdb/cli/cli-utils.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/gdb/cli/cli-utils.c b/gdb/cli/cli-utils.c
index a0ebc11..d59a231 100644
--- a/gdb/cli/cli-utils.c
+++ b/gdb/cli/cli-utils.c
@@ -146,7 +146,9 @@ get_number_or_range (struct get_number_or_range_state *state)
 	  temp = &state->end_ptr; 
 	  state->end_ptr = skip_spaces (state->string + 1);
 	  state->end_value = get_number (temp);
-	  if (state->end_value < state->last_retval) 
+	  if (state->end_value == 0)
+	    error (_("wrong value"));
+	  else if (state->end_value < state->last_retval) 
 	    {
 	      error (_("inverted range"));
 	    }
-- 
1.7.7.6


  parent reply	other threads:[~2014-03-13  2:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13  2:35 [PATCH 0/5] Return error code in get_number Yao Qi
2014-03-13  2:35 ` [PATCH 5/5] Accept convenience variable in commands -break-passcount and -break-commands Yao Qi
2014-03-14  8:22   ` Eli Zaretskii
2014-03-13  2:35 ` [PATCH 2/5] Change argument 'args' of get_tracepoint_by_number to char * Yao Qi
2014-03-13  2:35 ` [PATCH 4/5] get_number returns status in details Yao Qi
2014-03-13  2:35 ` [PATCH 1/5] Remove argument 'state' from get_tracepoint_by_number Yao Qi
2014-03-13  2:35 ` Yao Qi [this message]
2014-03-13 15:14 ` [PATCH 0/5] Return error code in get_number Tom Tromey
2014-03-14  0:59   ` Yao Qi
2014-03-14 14:38     ` Tom Tromey
2014-03-17  0:51       ` Yao Qi
2014-05-15 17:58         ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394677950-4054-4-git-send-email-yao@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox