From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/5] Return error code in get_number
Date: Thu, 13 Mar 2014 15:14:00 -0000 [thread overview]
Message-ID: <87d2hqku59.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1394677950-4054-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Thu, 13 Mar 2014 10:32:25 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> Patch #5 tries to teach GDB to accept convenience variable in MI
Yao> commands, in which we use get_number to parse string and get number.
Yao> However, get_number returns zero for any kinds of error, and callers
Yao> can't tell from it. Patch #4 changes get_number's interface to
Yao> return parsing status and parsed number. This patch also moves
Yao> some printing messages out of get_number, and let the callers to
Yao> print messages according to returned status.
Could you say what you want this for?
I don't understand why an MI client would ever use it.
Tom
next prev parent reply other threads:[~2014-03-13 15:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 2:35 Yao Qi
2014-03-13 2:35 ` [PATCH 4/5] get_number returns status in details Yao Qi
2014-03-13 2:35 ` [PATCH 5/5] Accept convenience variable in commands -break-passcount and -break-commands Yao Qi
2014-03-14 8:22 ` Eli Zaretskii
2014-03-13 2:35 ` [PATCH 2/5] Change argument 'args' of get_tracepoint_by_number to char * Yao Qi
2014-03-13 2:35 ` [PATCH 3/5] Emit wrong value error when parsing range Yao Qi
2014-03-13 2:35 ` [PATCH 1/5] Remove argument 'state' from get_tracepoint_by_number Yao Qi
2014-03-13 15:14 ` Tom Tromey [this message]
2014-03-14 0:59 ` [PATCH 0/5] Return error code in get_number Yao Qi
2014-03-14 14:38 ` Tom Tromey
2014-03-17 0:51 ` Yao Qi
2014-05-15 17:58 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2hqku59.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox