From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 5/5] Accept convenience variable in commands -break-passcount and -break-commands
Date: Fri, 14 Mar 2014 08:22:00 -0000 [thread overview]
Message-ID: <83mwgtmbow.fsf@gnu.org> (raw)
In-Reply-To: <1394677950-4054-6-git-send-email-yao@codesourcery.com>
> From: Yao Qi <yao@codesourcery.com>
> Date: Thu, 13 Mar 2014 10:32:30 +0800
>
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -95,6 +95,11 @@ PowerPC64 GNU/Linux little-endian powerpc64le-*-linux*
> and "assf"), have been deprecated. Use the "sharedlibrary" command, or
> its alias "share", instead.
>
> +* MI changes
> +
> + ** The commands -break-passcount and -break-commands accept convenience
> + variable as breakpoint number.
> +
Please say "variables" and "numbers", in plural.
Otherwise, this part of the patch is OK.
Thanks.
next prev parent reply other threads:[~2014-03-14 8:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 2:35 [PATCH 0/5] Return error code in get_number Yao Qi
2014-03-13 2:35 ` [PATCH 4/5] get_number returns status in details Yao Qi
2014-03-13 2:35 ` [PATCH 5/5] Accept convenience variable in commands -break-passcount and -break-commands Yao Qi
2014-03-14 8:22 ` Eli Zaretskii [this message]
2014-03-13 2:35 ` [PATCH 2/5] Change argument 'args' of get_tracepoint_by_number to char * Yao Qi
2014-03-13 2:35 ` [PATCH 3/5] Emit wrong value error when parsing range Yao Qi
2014-03-13 2:35 ` [PATCH 1/5] Remove argument 'state' from get_tracepoint_by_number Yao Qi
2014-03-13 15:14 ` [PATCH 0/5] Return error code in get_number Tom Tromey
2014-03-14 0:59 ` Yao Qi
2014-03-14 14:38 ` Tom Tromey
2014-03-17 0:51 ` Yao Qi
2014-05-15 17:58 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mwgtmbow.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox