From: Tom Tromey <tom@tromey.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH v4] Change some arguments to gdb::string_view instead of name+len
Date: Tue, 01 Oct 2019 17:18:00 -0000 [thread overview]
Message-ID: <87k19o4c5x.fsf@tromey.com> (raw)
In-Reply-To: <20190930200223.122452-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Mon, 30 Sep 2019 15:02:23 -0500")
>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:
Christian> [This version also replaces an instance of strcmp with string_view's
Christian> operator==, so that the length is correctly respected]
Thanks.
Unfortunately I found / remembered another weirdness.
Christian> - if (linkage_name[len] != '\0')
Christian> + if (linkage_name[linkage_name.length ()] != '\0')
This code let the caller pass in a possibly-unterminated string, and
then made a local copy with the terminating \0 in that case.
However, this was always a bad idea, and now is probably a libstdc++
debug-mode assertion failure (<- just guessing but if it isn't, it
should be!).
Tom
next prev parent reply other threads:[~2019-10-01 17:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 5:34 [PATCH] " Christian Biesinger via gdb-patches
2019-09-30 14:28 ` Tom Tromey
2019-09-30 14:38 ` Pedro Alves
2019-09-30 16:23 ` Tom Tromey
2019-09-30 19:33 ` Christian Biesinger via gdb-patches
2019-09-30 19:33 ` [PATCH v2] " Christian Biesinger via gdb-patches
2019-09-30 19:46 ` [PATCH v3] " Christian Biesinger via gdb-patches
2019-09-30 20:02 ` [PATCH v4] " Christian Biesinger via gdb-patches
2019-10-01 17:18 ` Tom Tromey [this message]
2019-10-01 17:26 ` Christian Biesinger via gdb-patches
2019-10-01 17:26 ` [PATCH] " Christian Biesinger via gdb-patches
2019-10-01 17:33 ` Christian Biesinger via gdb-patches
2019-10-01 18:23 ` Pedro Alves
2019-10-01 18:27 ` Christian Biesinger via gdb-patches
2019-10-01 18:31 ` Christian Biesinger via gdb-patches
2019-10-01 19:10 ` Pedro Alves
2019-10-01 19:30 ` Christian Biesinger via gdb-patches
2019-10-02 14:45 ` Pedro Alves
2019-10-02 18:44 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k19o4c5x.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox