From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71806 invoked by alias); 1 Oct 2019 17:18:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71797 invoked by uid 89); 1 Oct 2019 17:18:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.4.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Oct 2019 17:18:39 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 2033D401A20CF for ; Tue, 1 Oct 2019 11:11:52 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id FLnJid9aPBnGaFLnJinkNB; Tue, 01 Oct 2019 12:18:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kPUywXDpnCTtCo79DVAitxWAlkjYusrj6gYun9Ard4o=; b=m1KXlFKlKwHP/kyk8FePIzaqsT 5vbxqBfpaa0k+Auol1lFriX51gGeLVc9cZ5wrD2lr+/eIbj2SoCu6j7Oh8QG1ptqYbzjXaeBtUNKt D/KWWESAeN37mZn5IY8MaWlN3; Received: from 75-166-72-156.hlrn.qwest.net ([75.166.72.156]:42256 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iFLnI-0016L7-R1; Tue, 01 Oct 2019 11:18:37 -0600 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH v4] Change some arguments to gdb::string_view instead of name+len References: <20190930194621.168116-1-cbiesinger@google.com> <20190930200223.122452-1-cbiesinger@google.com> Date: Tue, 01 Oct 2019 17:18:00 -0000 In-Reply-To: <20190930200223.122452-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Mon, 30 Sep 2019 15:02:23 -0500") Message-ID: <87k19o4c5x.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-10/txt/msg00019.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> [This version also replaces an instance of strcmp with string_view's Christian> operator==, so that the length is correctly respected] Thanks. Unfortunately I found / remembered another weirdness. Christian> - if (linkage_name[len] != '\0') Christian> + if (linkage_name[linkage_name.length ()] != '\0') This code let the caller pass in a possibly-unterminated string, and then made a local copy with the terminating \0 in that case. However, this was always a bad idea, and now is probably a libstdc++ debug-mode assertion failure (<- just guessing but if it isn't, it should be!). Tom