From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,
Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>,
Christian Biesinger <cbiesinger@google.com>
Subject: Re: [PATCH] Change some arguments to gdb::string_view instead of name+len
Date: Mon, 30 Sep 2019 16:23:00 -0000 [thread overview]
Message-ID: <87muelah2g.fsf@tromey.com> (raw)
In-Reply-To: <3270c053-6981-edc5-e88a-6b836d9f1f24@redhat.com> (Pedro Alves's message of "Mon, 30 Sep 2019 15:38:43 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>> Maybe safest is just to transform it to a std::string here?
Pedro> Or
Pedro> "%.*s", name.size (), name.data ()
Yeah, even better; not sure why I didn't remember this.
Also I think it has to cast to int there.
Tom
next prev parent reply other threads:[~2019-09-30 16:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 5:34 Christian Biesinger via gdb-patches
2019-09-30 14:28 ` Tom Tromey
2019-09-30 14:38 ` Pedro Alves
2019-09-30 16:23 ` Tom Tromey [this message]
2019-09-30 19:33 ` Christian Biesinger via gdb-patches
2019-09-30 19:33 ` [PATCH v2] " Christian Biesinger via gdb-patches
2019-09-30 19:46 ` [PATCH v3] " Christian Biesinger via gdb-patches
2019-09-30 20:02 ` [PATCH v4] " Christian Biesinger via gdb-patches
2019-10-01 17:18 ` Tom Tromey
2019-10-01 17:26 ` Christian Biesinger via gdb-patches
2019-10-01 17:26 ` [PATCH] " Christian Biesinger via gdb-patches
2019-10-01 17:33 ` Christian Biesinger via gdb-patches
2019-10-01 18:23 ` Pedro Alves
2019-10-01 18:27 ` Christian Biesinger via gdb-patches
2019-10-01 18:31 ` Christian Biesinger via gdb-patches
2019-10-01 19:10 ` Pedro Alves
2019-10-01 19:30 ` Christian Biesinger via gdb-patches
2019-10-02 14:45 ` Pedro Alves
2019-10-02 18:44 ` Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muelah2g.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox