Re: [PATCH 1/2] gdb: don't print escape characters when a style is disabled

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> +# A replacement for the 'style' function found in gdb-utils.exp,
Andrew> +# filter out requests for the disabled style.
Andrew> +proc limited_style { str style } {

Rather than rename the global 'style', I think it would be fine to just
have a wrapper proc that is used locally.  That seems a lot less tricky.
Same with clean_restart.

Andrew>        /* Output pmatch with the highlight style.  */
Andrew> -      set_output_style (stream, highlight_style.style ());
Andrew> +      if (!highlight_style.style ().is_default ())
Andrew> +	set_output_style (stream, highlight_style.style ());

set_output_style ends up setting applied_style.
So avoiding this call seems iffy to me.

Maybe another approach would be to change emit_style_escape so that it
does nothing if the currently-applied style is equal to the passed-in
style?

Tom