From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Qz7YENeFCGApYgAAWB0awg (envelope-from ) for ; Wed, 20 Jan 2021 14:34:47 -0500 Received: by simark.ca (Postfix, from userid 112) id 37F6C1EF80; Wed, 20 Jan 2021 14:34:47 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D36421E590 for ; Wed, 20 Jan 2021 14:34:46 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 881C43877015; Wed, 20 Jan 2021 19:34:46 +0000 (GMT) Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.48.71]) by sourceware.org (Postfix) with ESMTPS id A8F403877015 for ; Wed, 20 Jan 2021 19:34:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A8F403877015 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 29FB025D992 for ; Wed, 20 Jan 2021 13:34:44 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2JFclyWXCSrGM2JFclkmnh; Wed, 20 Jan 2021 13:34:44 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SyF0dy4t87RP3kas+juvVtktUdpOxXzjSMe7S6cguGM=; b=Td1HApe9JFMth88t2NhWK+h21m bQGfbl5KltnVj+ULtWrS+X4EJtzGi3yWWptW18m/hb+WUONfBFZFQHeXae49EysRHyfn5/g6fb19q 1S1OFD/+kMmGzxDGhu5FGnv3n; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:57104 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l2JFb-0016Bh-Q5; Wed, 20 Jan 2021 12:34:43 -0700 From: Tom Tromey To: Andrew Burgess Subject: Re: [PATCH 1/2] gdb: don't print escape characters when a style is disabled References: X-Attribution: Tom Date: Wed, 20 Jan 2021 12:34:43 -0700 In-Reply-To: (Andrew Burgess's message of "Thu, 14 Jan 2021 09:56:42 +0000") Message-ID: <87k0s75rn0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l2JFb-0016Bh-Q5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:57104 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Andrew" == Andrew Burgess writes: Andrew> +# A replacement for the 'style' function found in gdb-utils.exp, Andrew> +# filter out requests for the disabled style. Andrew> +proc limited_style { str style } { Rather than rename the global 'style', I think it would be fine to just have a wrapper proc that is used locally. That seems a lot less tricky. Same with clean_restart. Andrew> /* Output pmatch with the highlight style. */ Andrew> - set_output_style (stream, highlight_style.style ()); Andrew> + if (!highlight_style.style ().is_default ()) Andrew> + set_output_style (stream, highlight_style.style ()); set_output_style ends up setting applied_style. So avoiding this call seems iffy to me. Maybe another approach would be to change emit_style_escape so that it does nothing if the currently-applied style is equal to the passed-in style? Tom