Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: don't print escape characters when a style is disabled
Date: Fri, 22 Jan 2021 08:26:06 -0700	[thread overview]
Message-ID: <87k0s5ouwh.fsf@tromey.com> (raw)
In-Reply-To: <20210121160808.GY265215@embecosm.com> (Andrew Burgess's message of "Thu, 21 Jan 2021 16:08:08 +0000")

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> OK, I think I have something working.  There were some issues with
Andrew> line wrapping, but I think that the final state is even better than
Andrew> the original patch.  Looking at some of the gdb.base/style.exp tests
Andrew> the set of escape sequences emitted now seems to be minimal.

Andrew> Let me know if this is what you were thinking of.

Thank you for doing this.
This looks good to me.

Tom

  reply	other threads:[~2021-01-22 15:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14  9:56 [PATCH 0/2] Style related fixes Andrew Burgess
2021-01-14  9:56 ` [PATCH 1/2] gdb: don't print escape characters when a style is disabled Andrew Burgess
2021-01-20 19:34   ` Tom Tromey
2021-01-21 12:06     ` Andrew Burgess
2021-01-21 16:08       ` Andrew Burgess
2021-01-22 15:26         ` Tom Tromey [this message]
2021-01-22 15:21       ` Tom Tromey
2021-01-14  9:56 ` [PATCH 2/2] gdb: add new version style Andrew Burgess
2021-01-14 10:35   ` Andrew Burgess
2021-01-14 11:15   ` Lancelot SIX via Gdb-patches
2021-01-20 19:39     ` Tom Tromey
2021-01-14 14:08   ` Eli Zaretskii via Gdb-patches
2021-01-20 19:39   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k0s5ouwh.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox