From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: add new version style
Date: Wed, 20 Jan 2021 12:39:38 -0700 [thread overview]
Message-ID: <87bldj5ret.fsf@tromey.com> (raw)
In-Reply-To: <04bf183a683d218b38a821a1108716191ea2cf22.1610618063.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Thu, 14 Jan 2021 09:56:43 +0000")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> gdb/ChangeLog:
Andrew> * cli/cli-style.c: Add 'cli/cli-setshow.h' include.
Andrew> (version_style): Define.
Andrew> (cli_style_option::cli_style_option): Add intensity parameter, and
Andrew> use as appropriate.
Andrew> (_initialize_cli_style): Register version style set/show commands.
Andrew> * cli/cli-style.h (cli_style_option): Add intensity parameter.
Andrew> (version_style): Declare.
Andrew> * top.c (print_gdb_version): Use version_stype, and styled_string
Andrew> to print the GDB version string.
Andrew> gdb/doc/ChangeLog:
Andrew> * gdb.texinfo (Output Styling): Document version style.
Andrew> gdb/testsuite/ChangeLog:
Andrew> * gdb.base/style.exp (run_style_tests): Add version string test.
Andrew> (test_startup_version_string): Use version style name.
Andrew> * lib/gdb-utils.exp (style): Handle version style name.
This looks good, thanks.
Tom
prev parent reply other threads:[~2021-01-20 19:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 9:56 [PATCH 0/2] Style related fixes Andrew Burgess
2021-01-14 9:56 ` [PATCH 1/2] gdb: don't print escape characters when a style is disabled Andrew Burgess
2021-01-20 19:34 ` Tom Tromey
2021-01-21 12:06 ` Andrew Burgess
2021-01-21 16:08 ` Andrew Burgess
2021-01-22 15:26 ` Tom Tromey
2021-01-22 15:21 ` Tom Tromey
2021-01-14 9:56 ` [PATCH 2/2] gdb: add new version style Andrew Burgess
2021-01-14 10:35 ` Andrew Burgess
2021-01-14 11:15 ` Lancelot SIX via Gdb-patches
2021-01-20 19:39 ` Tom Tromey
2021-01-14 14:08 ` Eli Zaretskii via Gdb-patches
2021-01-20 19:39 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bldj5ret.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox