From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cFWVHYGHCGDGYgAAWB0awg (envelope-from ) for ; Wed, 20 Jan 2021 14:41:53 -0500 Received: by simark.ca (Postfix, from userid 112) id 76D221EF80; Wed, 20 Jan 2021 14:41:53 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2960A1E590 for ; Wed, 20 Jan 2021 14:41:53 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E29BD385480B; Wed, 20 Jan 2021 19:41:52 +0000 (GMT) Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.50.93]) by sourceware.org (Postfix) with ESMTPS id 4AEEF385480B for ; Wed, 20 Jan 2021 19:41:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4AEEF385480B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 43827200CD for ; Wed, 20 Jan 2021 13:39:40 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2JKNl2i0uDT642JKOl1mgn; Wed, 20 Jan 2021 13:39:40 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8wzKWkENmXy9OFp4/FYzEK/SIsZCdYdWmsfSLqBVfU4=; b=aSVDuVGjOgSyDOAedfgEeZqhe4 dN58FAE40mnQ24d6OwbmsgZDA2qZJiN7J5RXLPekcrK/rhqolYok3VOQb3InOWKb5nPuZ8/SB4s2H GDnWh8mrQhJo4VUSwknyTKsWP; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:57118 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l2JKN-001AEO-FC; Wed, 20 Jan 2021 12:39:39 -0700 From: Tom Tromey To: Andrew Burgess Subject: Re: [PATCH 2/2] gdb: add new version style References: <04bf183a683d218b38a821a1108716191ea2cf22.1610618063.git.andrew.burgess@embecosm.com> X-Attribution: Tom Date: Wed, 20 Jan 2021 12:39:38 -0700 In-Reply-To: <04bf183a683d218b38a821a1108716191ea2cf22.1610618063.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Thu, 14 Jan 2021 09:56:43 +0000") Message-ID: <87bldj5ret.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l2JKN-001AEO-FC X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:57118 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Andrew" == Andrew Burgess writes: Andrew> gdb/ChangeLog: Andrew> * cli/cli-style.c: Add 'cli/cli-setshow.h' include. Andrew> (version_style): Define. Andrew> (cli_style_option::cli_style_option): Add intensity parameter, and Andrew> use as appropriate. Andrew> (_initialize_cli_style): Register version style set/show commands. Andrew> * cli/cli-style.h (cli_style_option): Add intensity parameter. Andrew> (version_style): Declare. Andrew> * top.c (print_gdb_version): Use version_stype, and styled_string Andrew> to print the GDB version string. Andrew> gdb/doc/ChangeLog: Andrew> * gdb.texinfo (Output Styling): Document version style. Andrew> gdb/testsuite/ChangeLog: Andrew> * gdb.base/style.exp (run_style_tests): Add version string test. Andrew> (test_startup_version_string): Use version style name. Andrew> * lib/gdb-utils.exp (style): Handle version style name. This looks good, thanks. Tom